Hello Everyone. I went over to my profile and noticed a few new things. Part of the learning curb.
Firstly, 4 of the 7 PR requests have a timer which says 'review period'. What does this mean?
Notably, the other PR's don't qualify for this hacktoberfest because they don't align with the values. I am unsure what this means other than there are certain rules and regulations set prior to the event which these projects did not 'live up to'.
Look forward to any feedback on my original questions. #thanks
Top comments (17)
it happened to me as well, then I checked the rules. this time hacktoberfest has offered 14 day time limit for maintainers to review the pull request. if your pull request is legit once it'll pass the time limit it'll become valid and will be counted towards winning hacktoberfest!
I just made my Pull requests today (October 19), and just realized they increased review period to 14 days meaning there wont be enough time to have my pr accepted within October. What should I do.
have the same problem, I'm curious if my PRs will be accepted in time
Same with me, This was my first HacktoberFest and it seems like my PRs wont get accepted anytime soon.
Fingers Crossed !!!!
From my understanding, the October 31st deadline is for submitting a PR. As long as it's not marked invalid during the 14-day maturing period, it'll count for the event (even if the maturing period goes beyond Oct 31st).
See the "Quality Standards" and "Bad repositories will be excluded" on hacktoberfest.digitalocean.com/det... for more information on why the repositories were excluded.
Thanks Ryan. But what is a review period? It says that my other four has 1 day left? Hope you can help! ;)
The review period is so that maintainers have a chance to review pull requests and mark any with an invalid tag for any that seem like they are made just to get +1 pull requests.
Thanks Ryan. ;) That makes more sense.
@ryansmith , what happens if the PR is not reviewed by the maintainer, or the PR is not marked with an invalid tag at all?
@sudo_kaizen In that case, it counts towards Hacktoberfest contributions after the review period.
ok.. that means, according to the hacktoberfest rules, merging a PR is not necessary only passing the review period is necessary.
I Pulled 4 PR on oct 1 and it was showing 7 days in review but after 3 days when submitted more PR.. the time period for all My PR review was shifted to 11 days . can anyone tell why did This happend.????
Yes, I had the same problem. I am guess that with so many people taking on the challenge, and so few hands on deck to check all PRs, that project owners were given more time. BUT...to be honest, I am not entirely sure. That is just a guess.
That Seems to be fine guess but will i able to get the reward for participating in this event because on 1 oct at 12 am my progress was filled with 4 PR.?? and whenever make more contribution, my review period for all PR increases by 1 day????? why
i have one more problem, today i made snake game using spyder4 as code editor but i cant able to execute or play the game. all code is correct, please suggest a platform for executing .py games. please.........
Does Someone know who has to review our PR.
Is it the owner of the Repository or someone from Hacktoberfest ?