DEV Community

An automatic interactive pre-commit checklist, in the style of infomercials

Victoria Drake on July 23, 2018

What's that, you say? You've become tired of regular old boring paper checklists? Well, my friend, today is your lucky day! You, yes, you, can beco...

Read full post

Nick Cinger • Jul 23 '18

This is soooo useful!
Thanks for sharing!

Ben Halpern • Jul 23 '18

Things like this are so much more valuable as a short post with some source code you can copy and paste and change if you like compared with creating a library for download which is basically a black box and users never really learn.

Victoria Drake • Jul 23 '18

Thanks guys! Glad it might be useful :)

Nick Cinger • Jul 23 '18

Exactly! I can already see how I'm going to tweak this for my team. The examples are readable and straightforward.

Luís Costa • Jul 24 '18

Awesome, thanks for sharing. Question though: what if I do want to force commit something, even I'm consciously aware that I can't check every item in the checklist? For instance, sometimes there's something breaking in production and we have to roll out an hotfix right away. This means that sometimes there's no ticket associated and we're damn sure that what we're releasing will fix the problem and not break anything else. This pre commit hook wouldn't let me commit in scenario, would it?

Victoria Drake • Jul 25 '18

In this specific scenario, yes, you'd probably just have to answer "Y" anyway. You'd really want to think of a checklist like this as a guideline rather than a rule anyway.

(+2 points if you name the reference)

Phil Boyd • Jul 30 '18 • Edited

The good thing is that even you fake the 'Y', it's still one more opportunity to think about what you're doing in the heat of battle; instead of just pressing send.

I need one of these on my emails :D

Victoria Drake • Jul 30 '18

Yup! My thinking too.

Valentin Pearce • Jul 26 '18

"The code is more what you'd call guidelines than actual rules"

It's nicely relevant to programming as well... I might make a wallpaper with that quote !

Vinícius Dantas • Jul 24 '18 • Edited

Well, I'd still go with automated tests, as a colleague suggested. I believe it is very dangerous to prevent commits. As long as it is a personal branch, one should go for it and do whatever they want.
Checklists? I'd surely add them to merge/pull requests.
As a midway point, I would run my checks while detaching from the terminal and returning a 0 exit code. That way, I would still have my checks while creating my commits and keeping changes safe in their place.

Something like:

#!/bin/bash

function main() {
    sleep 10
    echo 'Do my stuff'
}

main &
exit 0

Maybe some voice messages to give alerts etc, e.g., say when using OS X.

Before I forget and you think I came here to say it is a bad post: I totally loved it! :) It is very important to educate people on hooks

Jonathan Irvin • Sep 8 '18

I'm a big fan of Git and love writing about it. Hooks are one of those hidden gems that people rarely use. Thanks for enlightening us all!

Git is like an assembly line and as you write code and prepare to commit, there's a lot you can do along the process. This is DevOps 101. Asking questions precommit is a great way to keep yourself honest, but it's probably hard to enforce as a team. I would add using a solid PR template that asks these questions.

One thing this template may throttle is small commits. Forgive my strong opinions about Git, but I believe in small, agile, and transactional commits. This script might hinder that.

However, for someone starting out, it's a solid example to make sure you have your bases covered.

I would love to read more about using this method along the software development pipeline and employing checks and balances along the way to ensure solid code.

Ben Halpern • Jul 23 '18

Oh my god I need this!

I really do looove good status/error messages.

Victoria Drake • Jul 23 '18

Call now!!

What would your checklist be, Ben?

Ben Halpern • Jul 23 '18

The way my brain works, I feel nervous trying to define a checklist. Even though I know I have one. I have commitment issues. I'm going to give this a lot of thought from this post.

From reading your other stuff, I know I approach things in a much more abstract/chaotic way. I need all the help systematizing that I can get.

Victoria Drake • Jul 23 '18 • Edited

Good news: bash scripts, unlike comments on the Internet, are not publicly shared! :D You can have fun writing and rewriting all you like!

Case in point: this post does not contain my actual checklist. ^^;

kip • Jul 24 '18

I don't know if you know but you can set the scripts in any language to any hooks, not neccesarily bash, just set the correct shebang in the script and no more.

AllanLRH • Jul 25 '18

Haha, I could really use something like this, though I expect that it won't work well with the "commit often commit early" philosophy... and it could trip up GUI clients for those who use such abominations (ok, I also use them once in a while).

Muhammad Arslan Aslam • Jul 24 '18

I love it ♥️ ♥️ ♥️ You are a 🦄

Vlastimil Pospichal • Jul 23 '18

Instead of querying, I use automated tests.

Shreyas Minocha • Jul 23 '18

Whatever works for whoever.

Renich Bon Ciric • Jul 24 '18

You definitely made me smile!

Victoria Drake • Jul 25 '18

Maximilian Berkmann • Jul 25 '18 • Edited

This combined with automated testing systems would be amazing.

Robin Palotai • Nov 19 '19

Nice! See also pre-commit.com/. I wonder if such manual y/n questions can be integrated into that?

Derrick Bol • Jul 27 '18

Oh my gosh!! This is amazing! I can definitely see myself using this

Rafal Pienkowski • Jul 23 '18

I love automation over following conventions and/or checklists.

Great post!

Victoria Drake • Jul 23 '18

Thanks Rafal! Automation all the way!

Vlastimil Pospichal • Jul 24 '18

The problem with these three questions is that the developer learns to snap - without reading. Questions must include some relevant information, otherwise they are useless.