How to avoid difficult code reviews? Identify code smells!
According to Wikipedia:
In computer programming, a code smell is any characteristic in the source code of a program that possibly indicates a deeper problem.
After a few years of helping developers review code, I came up with 10 code smells and how to fix them while building my project Axolo.
🧐 Refactoring Large or Complex Methods
Navigating through methods that sprawl across numerous lines or twist into complexity can be daunting. Simplification is key!
The fix? Employ a linter to enforce a maximum number of lines. Deconstruct these behemoths into smaller, more focused methods, each dedicated to a singular task.
🤔 Addressing Long Parameter Lists
A lot of parameters can muddle method signatures, making them prone to mistakes.
The fix? Consolidate related parameters into a single object. Adopt the "parameter object" pattern to streamline your functions, enhancing their readability and maintainability.
🙄 Minimizing Excessive Comments
An overload of comments often signals that the code isn't speaking for itself as clearly as it should.
The fix? Strive for code that explains itself through judicious naming and structure. Reduce reliance on comments, allowing the code's purpose and function to be immediately apparent.
🤦 Eliminating Duplicate Code
Repetitive code fragments are not just a nuisance; they complicate updates and can introduce inconsistencies.
The fix? Seek out and consolidate repetitive code segments into common functions. Adhering to the DRY (Don't Repeat Yourself) principle simplifies future maintenance and modifications.
😕 Harmonizing Inconsistent Naming Conventions
Naming chaos confounds understanding and introduces potential errors.
The fix? Commit to a unified naming convention. Names that are clear and consistent pave the way for code that's more approachable and decipherable.
😬 Enhancing Error Handling
Neglecting comprehensive error management can lead to erratic behavior and a codebase that's tough to sustain.
The fix? Embrace thorough error management. Logically log and manage exceptions to bolster the code's stability and dependability.
🤯 Simplifying Overused If/Else Constructs
An abundance of if/else branches can tangle code, making it challenging to read and adjust.
The fix? Lean on data structures or design patterns, such as polymorphism, to untangle complex logic, thereby enhancing the code's legibility and adaptability.
👎 Refining Inheritance Usage
Inappropriate reliance on inheritance can entangle code further, reducing its adaptability.
The fix? Verify that inheritance is used judiciously. Opt for composition over inheritance to achieve a code structure that's more flexible and straightforward to maintain.
Be honest, which one do you usually see in your PR? If you think I'm missing something, let me know in the comments!
Top comments (1)
Great tips! Thanks