DEV Community

Jack Harner ๐Ÿš€
Jack Harner ๐Ÿš€

Posted on

Got My First Pull Request Accepted and Merged

Holy Shit, I Made Something That Someone Else Was Like "Ya, that works."

Check out my tiny little commit to the Dev.to repo here.

It's just a little 1 line change, but holy shit I'm excited.

Thanks Ben/Dev.to Team!

Discussion (30)

Collapse
dmahely profile image
Doaa Mahely

Great job!
I recently got my first PR merged to a google repo (!!!) and it felt awesome! It was the only thing I talked about for the rest of the day ๐Ÿ˜†
Mind you, it was just fixing a typo, but who knows what the next PR will be ๐Ÿ˜„

Collapse
jess profile image
Jess Lee (she/her)

๐Ÿ‘ ๐Ÿ‘ ๐Ÿ‘ ๐Ÿ‘

Collapse
jackharner profile image
Jack Harner ๐Ÿš€ Author

Happy to help!

Collapse
mnayeem profile image
Nayeem Rahman

Haha, first thing I ever did was correct an example in the w3c geometry module specification. Wasn't code (technically HTML I guess), and really all I did is post the issue that got fixed by someone else because I didn't know how to do that shit ๐Ÿคทโ€โ™‚๏ธ but damn was I excited.

Collapse
jackharner profile image
Jack Harner ๐Ÿš€ Author

It is a great feeling! Can't wait to contribute more.

Collapse
mjraadi profile image
Mohammadjavad Raadi

It's absolutely a satisfying feeling to get that "merge notification". I had my first PR to a public repo merged to react.js Farsi docs. Here's a link to it:

github.com/reactjs/fa.reactjs.org/...

Collapse
juanfrank77 profile image
Juan F Gonzalez

My first pull request was to one of the repos that looked for contributors. And I would only have found it thanks to dev.to

Collapse
guitarkat profile image
Kat • Edited on

It's a great feeling to help! :) Thank you for your contributions!

I remember making commits to documentation helping devs to understand concepts or a system so devs can use it more. :)

I do less code PR but put in recommendations for improvements or UX considerations or a suggestion for a fix.

Everything helps! :) Takes a team!

Collapse
rbo13 profile image
Richard Burk

Gz! ๐ŸŽ‰

Collapse
josephmancuso profile image
Joseph Mancuso

Open source is so incredibly amazing

Collapse
edisonywh profile image
Edison Yap • Edited on

Awesome man! Any tips for someone to start?

Collapse
jackharner profile image
Jack Harner ๐Ÿš€ Author

Just dig through repos. The Dev.To is a great one to start. Find a typo or something simple and fix it.

Collapse
dandevri profile image
Danny de Vries

๐ŸŽ‰

Collapse
techtalks profile image
Ankit Kumar

Great ๐Ÿ˜„

Collapse
hashimwarren profile image
Hashim Warren

Congrats! I can't wait for a chance to add to the commons.

Collapse
jackharner profile image
Jack Harner ๐Ÿš€ Author

It's funny. I was just clicking around on the site, saw that the comments link on the article excerpts just linked directly too the article. The comments section already had an ID assigned to it, so it was just adding the anchor tag to the end of the link!

Collapse
jeescu profile image
John Edward Escuyos • Edited on

Best feeling ever, especially if the PR was for different Organization. ehhh

Collapse
alahmadiq8 profile image
Mohammad Alahmadi

That's awesome! I can absolutely relate to that feeling when i had my first pr merged.

Collapse
jackharner profile image
Jack Harner ๐Ÿš€ Author

It does feel great! Can't wait to contribute to more things.

Collapse
nateous profile image
Nate

That feeling you get... Yes it is great! Good job!

Collapse
thobyv profile image
Thoby V ijishakin

๐Ÿ’ฅ๐Ÿ’ฅ๐Ÿป so cool

Collapse
theodesp profile image
Theofanis Despoudis

Yey

Collapse
samarkandiy profile image
Avaz Bokiev

Cool!

Collapse
jackharner profile image
Jack Harner ๐Ÿš€ Author

Thanks!

Collapse
onetwo profile image
Onetwo

Great!

Collapse
davidszabo97 profile image
Dรกvid Szabรณ

Awesome m8, keep it up!

Collapse
jackharner profile image
Jack Harner ๐Ÿš€ Author

Thanks!!

Collapse
ben profile image
Ben Halpern

And some new profile decor to boot!

Collapse
jackharner profile image
Jack Harner ๐Ÿš€ Author

I'll wear it with honor!

Collapse
filsuck profile image
Filsuck

That's really exciting, glad to hear it, I know how that feels!