DEV Community

Priya Kothalkar
Priya Kothalkar

Posted on

My Portfolio

My #Portfolio contains Projects, Blogs, Skills and Social media links.
https://priya-kothalkar.netlify.app/

You can have a look, and if you have any suggestions please let me know in comments.
Thank you!

Top comments (2)

Collapse
 
charliejoel profile image
Charlie Joel

Great looking stuff here! Seems like you're super into JavaScript which is great.

One suggestion I have is to try using a system like BEM to organise your CSS, it's worth learning and makes CSS a lot less complicated. It's simple to get started with and looks great to employers.

It might make your life a bit easier when it comes to spacing too - for instance, your headings (like the 'Technologies' heading) has some extra padding on top compared to the bottom. I think this is because you have both top and bottom margins on all the H1 tags. A way to improve this might be to create a .heading class which only has bottom margins and no top margin - this way, your container can deal with the padding and the H1 only has to have bottom margin and you won't get this doubled up spacing issue.

I really liked the concept behind the emoji encyclopedia! I had a look at the source code and your JS is looking great. Something I've recently tried which might improve it is that when the user is inputting text, it's useful to turn anything you're comparing to lowercase so the search isn't case sensitive. I know it's meant to be for finding the names of emojis, but you could also make it find the emoji by name by searching the names if the emoji wasn't directly found.

You could turn emojiDictionary into an array of the emoji names using Object.values(emojiDictionary).
Then you could search for the user input using:
Object.values(emojiDictionary).indexOf(emojiName => emojiName.toLowerCase().includes(userInput.toLowerCase()))
You get the index of that emoji and use the index to find the correct emoji.
Object.keys(emojiDictionary)[index]

Just as a suggestion! But this looks like a great start , it's great that you're working on React projects. Keep it up :)

BEM: getbem.com/

Collapse
 
kothalkarpriya profile image
Priya Kothalkar

Thank you so much for your suggestion. I am glad that you liked my project. I'll try to look upon the things you suggested