DEV Community

Peter Wan
Peter Wan

Posted on

Continuous contributions

Following up on my last blog, I've been aiming to learn more about browser extension development through practical experience. In particular, I've been trying my hand at contributing to the open-source project, ImprovedTube, which enhances one's viewing experience on YouTube. The source code for ImprovedTube can be found below:

GitHub logo code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}

/ImprovedTube/ a powerful but lightweight extension,
to enrich your video experience & enable your content selection
Top 50recommended by firefox g 'Might
be the only YouTube Extension you'll ever need'
'enhances YouTube in meaningful ways'
'Strong Add-on, full control. Yet clear & easy'

Thanks ♡ to our contributors, Alan Tan, Raszpl
translators (+ wiki-authors? +donators?):bowtie:

Original introduction

«Improve YouTube!»   

/ImprovedTube/ is a strong & lightweight extension! - 80 features / the only one of a kind!

Since 2012 we have gradually been adding lightweight features, while keeping up with Youtube changes. (throughout the years we witnessed the birth & fall of other promising & open YouTube Extensions 1, 2, ... ) Today adding features can be easier & so motivating as there are 500 000 users. [👪Join us].

Currently, I've been researching a family of related issues pertaining to ImprovedTube's Cinema Mode setting. Cinema Mode is a neat feature that hides all of the clutter on YouTube as you're watching a video.

In the screenshot below, you can see that on the top-right, ImprovedTube provides a switch that lets you enable the Cinema Mode button shown on the YouTube player (NOTE: whenever I say switch, I am referring to the setting at the top-right, whenever I say button, I am referring to what's on the YouTube player).

cinema-mode

If I actually press on the Cinema Mode button, you'll notice that many things disappear - video suggestions, comments, etc.

cinema-mode-in-use

This feature is really neat! But as I was testing this feature personally, I noticed some inconsistencies with how the extension behaved. The most apparent inconsistency was that I expected to see the Cinema Mode button disappear if I disabled the Cinema Mode switch, and similarly, I expected the Cinema Mode button to appear if I toggle the Cinema Mode switch on. Long story short - the toggle switch wasn't working as expected. Whenever I tried to disable the Cinema Mode switch, I noticed that the YouTube Player button still persisted. I was confident that this was not the expected behaviour either since ImprovedTube's other toggle switches would cause their respective buttons to appear or disappear accordingly. As such, I logged this issue: https://github.com/code-charity/youtube/issues/2700 (you can see exactly what I mean because I posted a video showcasing the issue).

I noticed that there was a lot of "buzz" around the Cinema Mode option in general(you can see that I linked some other related issues and pull requests), and so on the particular issue that I logged, I wanted to be very specific as to what I thought was wrong, and what I thought should be changed.

I volunteered to fix the issue that I brought up because I think that I had a clear expectation on how this issue should look like once it's been resolved. I also logged this issue to help me get into the flow of trying to fix some of the other issues related to the Cinema Mode setting. While I haven't exactly figured out the exact expected behaviour of the other issues yet, I will carefully review them later.

For now, I'll leave you with the pull request that I made, which hopefully, fixes the weird behaviour I stated in my issue: https://github.com/code-charity/youtube/pull/2701.

Top comments (0)