DEV Community

Cover image for This is my first project! Please give feedback
Rahman
Rahman

Posted on • Updated on <time datetime="2020-06-24T06:06:30Z" class="date">Jun 24, 2020</time>

This is my first project! Please give feedback

Hello, This is my first freecodecamp project . Give me any type of feedback . And how I can improve my frontend effeciency ??

Thank You!

Discussion (9)

Collapse
vincenius profile image
Vincent Will

Really good for the first project :)
From design perspective, I'd add some padding on the left and right, at least for mobile view.

For code, you should add some description in the alt="" tags of the images. Also, add a rel="noopener norefferer" to your links if you use target="_blank" because of security reasons (web.dev/external-anchors-use-rel-n...)

But all in all, it's pretty solid :)

Collapse
rahmanxyz profile image
Rahman Author

Amazing .. I learned something new ... thank you brother

Collapse
atulcodex profile image
Atul Prajapati

first project me hi, rula diya yaar 😥😪

Collapse
rahmanxyz profile image
Rahman Author

yupp bro 😥😥😥😥

Collapse
h1manshu01 profile image
Himanshu Sharma

😄😄

Collapse
atulcodex profile image
Atul Prajapati

Sure ✌️

Collapse
miketalbot profile image
Mike Talbot

Hey that's nice! As Vincent mentioned the only thing I'd also say is padding. It makes it feel cramped when it's jammed up against the edges of the frame. Excellent work though!

Collapse
rahmanxyz profile image
Rahman Author

thank buddy .. after add padding its look better

Collapse
Sloan, the sloth mascot
Comment deleted