DEV Community

Yuri Alves
Yuri Alves

Posted on

Roast my site

SPFound is Where you can find help for your latest side projects or find side projects to help.

Website: https://spfound.netlify.com

Discussion (22)

Collapse
moopet profile image
Ben Sinclair

I like the way the business casual guy's mourning the loss of his upright vacuum cleaner. He's still got little purple dust bunnies to deal with but it's too late.

On a more serious note, I get the local development settings when I hit "log in", so there's a step missing in your deployment somewhere.

Collapse
larizzatg profile image
Larizza Tueros
  • I like the text effect of the introduction and the font family for the title but it's too much for the lines. Instead use Righteous,cursive for the lines;

  • When no results are found the page jumps to the top. You can prevent this if you put a div with some padding and the default text that everyone already told you about.

  • Padding is your friend to create breath and space! Decrease the margin of product cards and add more padding (mainly on the top/bottom) to it. If you do it it's going to look off, that's because you had to put top:0 to the ProductCards Content

  • Add more padding (x) to the introduction on mobile

  • Add more margin (y) to the ProductCards on mobile.

I'm enamored with the logo and the header.

Collapse
wattafot profile image
wattafot • Edited on

First of all, great job dude!
i like your background, where i can get those images from?
i dont like the font u are using beneath the headline. its kinda hard to read for me. maybe change that :)

go on!

Collapse
yuriguernsey profile image
Yuri Alves Author

Thank you, I got it from undraw.com. I'll definitely change the font.

Collapse
grodier profile image
George Rodier

I'm hesitant to provide anything critical, because I know the hard work that goes into putting a product out there and overall I think it's a great job. So I'll evaluate from a user experience perspective.

For me, I'm not a fan of the text under "Welcome to SPFound". The letters appear too close together and coupled with the fact that it's on a slant, it makes it hard for me to read.

I also think the filter by category is a little confusing. It's hard to tell by clicking on a category if anything is happening. It wasn't until I clicked on Software when everything disappeared did I realize that it was filtering and at that point it removed everything. A couple suggestions for improvements would be:

  • Only have filtering categories if an item exists in that category. So there may not be a need to include a Software filter currently.
  • Indicate somehow which one is the active filter. If I click on website, maybe it should indicate that filter is active and clicking it again would remove it.
  • I think the filters are a great thing to have in the future, but they may not be needed while the list is small and easy to see. Only when it becomes larger are they more important. Otherwise their functionality may be confusing.

Hope those suggestions help to spark some creative ideas. Great work!

Collapse
rvarela94 profile image
Mr. Varela πŸ‘ŒπŸ»

A couple of notes:

  • With 1920 x 1080 resolution, the small text on the title is overlaid. I advise you to correct the "line1" and "line2" height. @media screen and (min-width: 1400px){ line1{ height: 45% -> 50%;} line2{ height: 49% -> 55%;}}

  • Maybe it's on purpose, but the image disappears at 971px width while testing for responsiveness to minimum possible width. You could place the image between the blue background and the title between 730px and 971px.

  • Maybe add some text when there's no results for a category.

Keep up the good work!

Collapse
yuriguernsey profile image
Yuri Alves Author

Thank you for the feedback. I really appreciate it. I will start working on those points right away.

Collapse
jsrn profile image
James
  • If there are no results for a category, it'd be nice to convey that to the user somehow, rather than leaving it totally blank.
  • Having a "Home" button in the nav bar feels a bit redundant on a single page app.

Really love the header.

Collapse
yuriguernsey profile image
Yuri Alves Author

Thank you for the feedback. I will be sure to add some text to inform users when there are no results.

The website does have another page, but I still have yet to finish the page before implementing it to the website.

Collapse
pol_wekesir profile image
wekesir

On a desktop, I think the links at the top right of the navbar need a little more spacing between them. Just for elegance

Collapse
yuriguernsey profile image
Yuri Alves Author

Ok, I will be sure to add it now

Collapse
kevinhch profile image
Kevin • Edited on

the product cards should have a margin top and bottom in mobile view, and the nav bar should be stay too.

Collapse
dtrancloudguru profile image
dtrancloudguru

The banner looks like you're trying to sell me something

Collapse
yuriguernsey profile image
Yuri Alves Author

Is that not the right approach?

Collapse
niorad profile image
Antonio Radovcic

the header-banner-layout is broken and nothing happens when I click the projects on the bottom.

Collapse
yuriguernsey profile image
Yuri Alves Author

Thank you for pointing that out to me. I will be sure to fix these problems soon.

Collapse
kevinhch profile image
Kevin • Edited on

check your console, it has an infinite error messages of "VM10860:1 Uncaught SyntaxError: Unexpected identifier"

Collapse
yuriguernsey profile image
Yuri Alves Author

Oh, I see that error now. It only happens when you press the 'All' Filter button.

Thank you for pointing that out to me.

Collapse
camto profile image
Benjamin Philippe Applegate • Edited on

It's a tiny nitpick but dang the shade of blue on the project cards is just burning my retinas. Also how the view moves around jankily when changing filters.

Collapse
yuriguernsey profile image
Yuri Alves Author

All feedback is appreciated even if it’s tiny.
Anyways, I will sort that out as soon as possible.

Collapse
watzon profile image
Chris Watson

Was this your 2 year old's first website? πŸ˜‰

Collapse
yuriguernsey profile image
Yuri Alves Author

Ouch that hurt haha. πŸ˜­πŸ˜­πŸ˜‚