DEV Community

Cover image for Pull Requests: The Good, The Bad and The Ugly
Viach Kakovskyi
Viach Kakovskyi

Posted on

9 2

Pull Requests: The Good, The Bad and The Ugly

Hostinger image

Get n8n VPS hosting 3x cheaper than a cloud solution

Get fast, easy, secure n8n VPS hosting from $4.99/mo at Hostinger. Automate any workflow using a pre-installed n8n application and no-code customization.

Start now

Top comments (4)

Collapse
 
stecman profile image
Stephen Holdaway

Nice - more information is always better. The "why" of changes is particularly important for other devs and future you.

One step better is writing your detailed descriptions in the body of commit messages; then it's in the history and directly accessible through whatever interface you use to git blame. All of the Git web platforms support this well, including copying the commit body to the description of a pull request.

Facebook's tool Phabricator has an excellent article on writing reviewable code + writing good commit messages which goes into more detail.

Collapse
 
backendandbbq profile image
Viach Kakovskyi

Completely agree. The article which you mentioned is a great guidance.

Collapse
 
connorphee profile image
Connor Phee

Really enjoyed reading this! My team is currently trying to improve our process and I think you had some really good points/ideas that I will bring up to them!

Collapse
 
backendandbbq profile image
Viach Kakovskyi

That's great, Connor! All the things in the blog post are based on my practical experience playing as a team.

Eliminate Context Switching and Maximize Productivity

Pieces.app

Pieces Copilot is your personalized workflow assistant, working alongside your favorite apps. Ask questions about entire repositories, generate contextualized code, save and reuse useful snippets, and streamline your development process.

Learn more

👋 Kindness is contagious

Please leave a ❤️ or a friendly comment on this post if you found it helpful!

Okay