It’s the second week of Hacktoberfest and there’s no better way to celebrate that than to highlight the amazing people in our community who have contributed to Forem's codebase!
We’re thrilled to share that we’ve had 5 contributors in just a few short days commit improvements across the many projects we have in our web, iOS, and Android apps 🎉
Thanks to the help of these wonderful contributors, we’ve merged all 5 PRs this week. Forem is still a small team so this amount of feature-building and bug-squashing is truly only enabled because of the community. As Forem grows, we intend to continue enabling the open source community to improve and expand our offerings with their invaluable help. We appreciate the contributors for helping us sow this open source commitment from day one.
If you are interested in contributing check out our post on Forem projects you can contribute to this Hacktoberfest.
In no particular order, here are the folks who made commits this week, their GitHub profiles, and their merged PRs.
Manage listing categories in dashboard
#10506
What type of PR is this?
- [ ] Refactor
- [x] Feature
- [ ] Bug Fix
- [ ] Optimization
- [ ] Documentation Update
Description
It adds ability to add/update/remove listing categories in admin panel
Related Tickets & Documents
closes https://github.com/forem/forem/issues/10481
QA Instructions, Screenshots, Recordings
https://vimeo.com/463735841/dfe6705dab
Added tests?
- [x] yes
- [ ] no, because they aren't needed
- [ ] no, because I need help
Added to documentation?
- [ ] docs.forem.com
- [ ] readme
- [x] no documentation needed
Disable autoplay on native videos
#10516
What type of PR is this? (check all applicable)
- [ ] Refactor
- [x] Feature? or is it
- [ ] Bug Fix
- [ ] Optimization
- [ ] Documentation Update
Description
I'm not sure it 100% closes #6067 because the issue refers to a user setting for video autoplay.
The general consensus, for the moment, was to simply disable autoplay.
The autostart value was removed since it defaults to false, and the play() on ready was also removed.
Related Tickets & Documents
#6067
QA Instructions, Screenshots, Recordings
- Load up any article with a native video
- Verify that it doesn't autoplay
Added tests?
- [ ] yes
- [x] no, because they aren't needed
- [ ] no, because I need help
Added to documentation?
- [ ] docs.forem.com
- [ ] readme
- [x] no documentation needed
Updated minimum requirements for local installation on Windows
#10513
What type of PR is this? (check all applicable)
- [ ] Refactor
- [ ] Feature
- [ ] Bug Fix
- [ ] Optimization
- [x] Documentation Update
Description
Windows recently extended WSL 2 support for more versions/ builds. Updated the prerequisites to the exact versions given in Microsoft Docs.
Related Tickets & Documents
- #10438
- Microsoft Docs for WSL Installation
- Microsoft blog on extending WSL 2 support to other versions
QA Instructions, Screenshots, Recordings
No need for QA
Added tests?
- [ ] yes
- [X] no, because they aren't needed
- [ ] no, because I need help
Added to documentation?
- [X] docs.forem.com
- [ ] readme
- [ ] no documentation needed
added z-index to post editor options dropdown
#10536
What type of PR is this? (check all applicable)
- [ ] Refactor
- [ ] Feature
- [x] Bug Fix
- [ ] Optimization
- [ ] Documentation Update
Description
Added z-index to the post editor options dropdown to make sure that it always stays on top of other content.
Related Tickets & Documents
Fixes #10531
QA Instructions, Screenshots, Recordings
Before
After
Added tests?
- [ ] yes
- [x] no, because they aren't needed
- [ ] no, because I need help
Added to documentation?
- [ ] docs.forem.com
- [ ] readme
- [x] no documentation needed
Fixes 500 error when viewing the "Tag Mods" page without having the role on the database
#10515
What type of PR is this? (check all applicable)
- [x] Refactor
- [ ] Feature
- [ ] Bug Fix
- [ ] Optimization
- [ ] Documentation Update
Description
I think that the issue (#10060) is self-explanatory. What was happening with @msarit was that she was visiting the /admin/mods?state=tag_moderator without having a role named tag_moderator on the database.
The query class explicitly "blew up" in this condition. I tried to follow the approach proposed by @Zhao-Andy:
-
The query class now doesn't raise an exception in the scenario above. Instead returns an empty result set
-
The mods page now returns a generic "there are mods matching your search" warning if there are no mods matching the query
Related Tickets & Documents
#10060
QA Instructions, Screenshots, Recordings
-
Go to the
/admin/modspage -
Search by a random text string which yields no results and see that a "no results" message is rendered
-
Delete the
tag_moderatorrole from your database (Role.find_by(name: "tag_moderator").delete) -
Go to
/admin/mods?state=tag_moderator -
See that a "no results" message is rendered
Added tests?
- [x] yes
- [ ] no, because they aren't needed
- [ ] no, because I need help
Added to documentation?
- [ ] docs.forem.com
- [ ] readme
- [x] no documentation needed
Thanks again for improving both Forem and the broader open source community by participating in Hacktoberfest. Happy coding!
Top comments (7)
Great work @rafi993 , @reobin , @sabarishcodes , @_akshaym , and @diogoosorio ! 👏👏👏
Awesome job, y'all! The Forem team appreciates your contributions ❤️
Thank you @jess
Thanks Jess :)
Thanks for the recognition Christina and to the Dev Team :) I also earned a cool badge for contributing :p
Woohoo! Thank you for your contribution. It is greatly appreciated!
Team work makes the dream work @rafi993 , @reobin , @sabarishcodes , @_akshaym , and @diogoosorio ! Great job!