Here's the link to the website, it is a tribute page.
GuruTheCoder's tribute page
GuruTheCoder
Posted on
I've made a website! Need feedback
For further actions, you may consider blocking this person and/or reporting abuse
Discussion (17)
Freecodecamp folks?
Anyway, it is not bad tbh.
One major suggestion:
Don't use
text-align: centerorjustifyon long paragraphs. Reading becomes an eyesore.Also, I'd highly recommend increasing the font size of the heading in orange section, and make the button at the end a bit bigger, too...
Anyways, great job! Keep up the good work!
Yes I'm from FCC.
What SHOULD I use instead of text-align:center;
Okay I'll apply all those stuff.
Thanks!!
text-align: left. It is the default...Best of luck!
Thanks! I'll remove that!
it's a good starting for a beginner.
Here are some suggestions from me:-
Don't use Id to style an element, use class.
Id automatically creates properties on global window object in JS.
Good luck.
Don't set a height on your image in your CSS. On my massive monitor his picture becomes very wide, on mobile his image becomes very thin.
So two things to look at / learn from:
If you do a bit of research on both of the above and then ask any questions on anything you get stuck on!
Good luck with the site!
Thank you very much!
Why you have used strong tag in h3 tag without altering the font-weight ?
If you are using any title with background and width 100% to it's parent, then center the title.
And paragraphs you can use a single paragraph and break it with br
Or try using list components more instead of paragraph
And use classes for styling, bcz classes specificity is lesser than I'ds, and I'ds should be unique, class can be reused but an I'd cannot,
That's why most of them uses classes for styling and I'ds for navigation
Pictures will be like blownout to the maximum width until unless you learn responsive way using grid or flex and combine image with headings and stuff when the screen size is grown or remove them when screen is shrinked
These were upto my knowledge As usual I might be wrong
Okay I'll fix those things.
When I created this post, for me, it was all about making it look good. I didn't care much about responsiveness. Now, after just a few months, I've learnt a lot! These comments were all really useful. I wouldn't be able to implement what you guys asked me to do without knowing what I know now. I actually forgot about this post.
Good work! I would remove the steve jobs under the picture of him. The reader already know who they're looking at due to the title and opening line.
Okay!
Change the
widthproperty of Steve's picture tomax-width: 100%;that way, no matter the screen size, the width will be appropriate.Nice site by the way, I like the colour
Okay!
All done!!! I taken all your feedback and improved upon it. It'd be great if you could tell me how I could improve further. Or if this project is so great that I deserve a noble prize.
wide steve
I'll fix that 😂