DEV Community

James MacIvor
James MacIvor

Posted on • Originally published at macivortech.com on

Tale of Terror - A Scary Web Dev Story

Tale of Terror - A Scary Web Dev Story

A collection of lit jackolanterns with a dark background.

Mark Menzies

Intro

Wes Bos asked for scary stories on Twitter recently. I emailed him but was inspired to write about it myself.Update! My story was read on SyntaxFM ep. 294 starting on 40:19! Thank you Wes Bos and Scott Tolinski!

A Warm October

My story takes place many years ago. I was hired by a consulting company to work on an EPiServer (CMS) implementation for a client. My skill level at the time was probably just barely mid-level, but mainly in C# and .NET tech, not so much with JavaScript. I was a pretty fair hand with the internals of the CMS though so I thought I could figure it out, also I reasoned that my tech lead had a decade of experience so I could lean on him a little bit.

Arriving on site, the first thing the client told us was "No frameworks, plain JavaScript / jQuery only".

Okay, I thought, but then won't it take longer for us to have a reactive site? But there was more.

"We'll be ajaxing in the widgets from the CMS to other projects so the JavaScript can't conflict with any of those projects." When I asked what version of jQuery the other projects were using he said "Oh, various. Some are on version 2, others on version 1.9. That's not a problem, right?"

This sounded bad to me - wouldn't that be rough to know whether our code would work if we couldn't be sure what dependencies were available?

My tech lead was confident though - "No problem! We can do it!"

Okay, whew, well at least my tech lead had the goods. Over the next week or so while we familiarized with the project, the client would make some more restrictions around the JavaScript and CSS to use. Like no build steps for JavaScript, no jQuery plugins, etc etc.

The tech lead would sagely nod his head. "No problem!" He'd say.

A Cold November

One day I was working on some frontend stuff and had a problem. I was inexperienced with JavaScript and CSS and some elements just would not position themselves correctly. I asked my tech lead for help. As I'm explaining the problem he gestures at my screen and says "What is this tool you're using here?"

I had a dual monitor set up. One screen had the page and the other had Chrome Dev Tools. I didn't have anything fancy on the screen so I was puzzled.

"What do you mean? The console? Or something else?"

"No, what is this tool? It seems pretty useful."

"You mean... Chrome Dev Tools?"

"Oh! Is that what that is? That's built into Chrome then?"

My heart was in my stomach. Did he not know Chrome Dev Tools? What else might he not know? Am I the one who's wrong? Maybe dev tools aren't standard tooling for all web dev.

From a place of pure self doubt I withheld judgement and explained the tools. Then I asked "So what do you use?"

He showed me how he worked through JavaScript using an elaborate system of alert statements to debug his code. I kept my face straight, but internally I knew. I was in danger.

I soon learned that he also didn't know MVC. He also didn't know JavaScript too well. He asked me if I had ever used Moo Tools. This was the first time I had ever heard of Moo Tools. (It was a competitor for jQuery in like 2006 FYI.)

"I'm so glad you're on this project and can help me out with this stuff." He said to me one day.

Cold sweat trickled down my spine. I smiled.

"Sure. No problem."

Over the weeks he struggles with user stories and I pick up more. Soon, the client was bypassing him and asking me directly to plan and implement the features.

The Real Horror Begins

I, barely a midlevel developer, start to plan the architecture of our little piece of the project. The .NET piece seems fine just following the established patterns I already knew. The JavaScript left a lot to be desired.

I read a lot. I made friends with developers on other projects and started asking them lots of questions. I was determined to nail this. I believed I could do it.

I decided that since we couldn't use frameworks but needed framework like behavior then I would build my own custom framework. A mini-framework. Just enough to get things working. I started writing JavaScript - a lot of JavaScript!

I had read about something called MutationObserver which is something in JavaScript that allowed me to observe changes to elements and then react to them. I decided that would be the core of my project. I built a central engine around this. I made JavaScript functions representing pieces of functionality I needed and overloaded the prototype to get the functionality I needed.

I created a custom dependency injection setup for my functions. I believed I could create something similar to Angular.js, just a touch simpler. I worked late every night for weeks. I was marking features as completed but I would frequently revisit them.

Really, nothing was ever finished because I kept changing it.

I worked into a delirium. I worked until I thought I was crazy.

I believed, I really believed I was making a fairy tale palace of JavaScript. You read this and you think you know how bad it was.

It was worse.

The Dungeon

Things were getting close to completed, or so I thought. But everything always seemed to be broken.

Things happened on the site but I had no idea why. Race conditions abounded. The off-by-one errors had off-by-one errors.

Slowly, painfully, I began to realize that this was my fault. My design was flawed. My assumptions, wrong. All the work, the long hours - wasted. I became bitter.

I was behind schedule but I was not alone. Every project the client had seemed to be struggling. The depth of the issues in the application I was working were lost as other pieces of the project seemed to fly off the rails. One project team eventually admitted they had completely forgot to implement security. Other teams scrambled to offer personnel for a "security task force" to "shore up" the security. One senior level project manager joked "Well it's like we built the car and forgot to put locks on the doors 🤷‍♂️ Oopsies!"

I kept sliding more and more fixes in, trying to fix my app - to make it good even. A good result seemed so close, yet so far away. I started to feel trapped within a prison of my own making. No one could really help me either. My tech lead was still there, but seemed lost and confused. He had been marginalized and now I owned this mess. The consultancy had long ago let me know that their hands were tied. I had made them aware of the situation with the tech lead and they had confirmed the problem, but could not act without disrupting the project.

I had turned this opportunity into an exercise in hubris.

The client, realizing that there might be some issues maintaining the application after I left, assigned one of their own developers to the team. I went over the project and we laughed at it with typical gallows humor. We were now both imprisoned.

However, things started getting better. Now I had someone to bounce ideas off of. We began to conspire a way out of this mess. We were going to introduce Vue.js.

Perhaps I would not be hoisted by my own petard!

Vue.js was designed around being able to incrementally refactor. It was small and fast and we didn't need anything except the core functionality. It worked just fine alongside jQuery and we found a way to make it work with Angular.js.

We were saved!

Slowly, we started to see bugs disappear. Things were working faster and more reliably. The code started to look less like a mess and more like something we could maintain.

But the project as a whole was not getting better. Project management wanted more late nights. They wanted more sacrifices. Code for the Code God!

Escape From New Work

At last, I had enough. I'd worked on the project for about 8 months and I didn't see anything that made me want to stay.

The consultancy I worked for had promised a $500 bonus if I stayed another 7 months, but I wasn't interested in peanuts. The client had pulled me into a room with three project managers and let me know it was time to start working 12 hour days. When I refused ( I wasn't getting paid for that time after all ) the handler from the consultancy emailed me from his tropical vacation letting me know that "You will comply with the overtime request."

It was time to get out.

The box art for the 90s classic film: Escape From New York with title changed from New York to New Work <!---->

I did have one person who I owed an explanation though, and that was my co-conspirator developer who helped introduce Vue.js. Thing was, he completely understood - in fact he was already looking too. We were going to abandon this project and let this app fend for itself. The Vue.js refactoring had a long way to go, but neither of us could stomach the other dysfunctional pieces of the project.

I found another job that prioritized work/life balance and left. After a couple of weeks I referred my new friend and he left as well.

We ran out like the building was on fire.

Beware

That project is still there. Years later I saw wanted ads from the company. "EPiServer developer needed! JavaScript experience a must! Vue.js experience preferred!"

The refactor is still in progress. The old broken JavaScript still scraping by.

Fellow developers, the dungeon I created still exists, seeking new inmates. That JavaScript "framework", a monster that few can slay. When you're out there, scrolling through ads thinking about your next gig, remember this.

Be diligent lest you also be imprisoned!

But Hey I'm Fine

A guy at a computer desk hoists his mug at the camera. A caption reads 'Writes Unmaintainable Code, Leaves Company'

Is this me? Am I the monster?

Top comments (5)

Collapse
 
tominekan profile image
Tomi Adenekan

Very interesting story.The blame lies on several people.

The Client
They did not have a solid, unchanging set of rules, instead the rules got stricter, changing the approach needed for the job. Very bad indeed.

The Tech Lead
From your story, it appears that the tech lead had no idea what they were doing, a tech lead is supposed to lead the team, not the other way around.

Your fault (kind of)
You didn't get away fast enough :)

Collapse
 
robotoptimist profile image
James MacIvor

I think I could have done a better job being honest with the client about my capabilities (or lack thereof). I was scared they'd come down on me though, and the consulting firm that employed me was not very helpful around that.

If I had it to do over again I would have been honest with the client and say:

"Hey, I don't know how to do what you need in a maintainable best-practice type way."

Rather than trying to invent my way out of it I should have given them the opportunity to address the problem and hopefully have been part of a better solution. That would have been better for everyone, especially me.

I think to do that I would have needed more confidence around what happens if I get fired. As a contractor at the time, I felt even more uncertain. Me admitting that I don't know what I'm doing doesn't just make me look bad, but also the consulting firm (who probably 'sold' me to the client by exaggerating my experience).

This is all in hindsight though, so it's easy to imagine doing the right thing. :D
Definitely leaving the consulting firm that created the situation was the right call though.

Collapse
 
tominekan profile image
Tomi Adenekan • Edited

I don't know about that. It seemed like the tech lead was just taking all of the requests and did not know when to say enough is enough. But case in point, I do believe that you could have told someone (at least the tech lead) that what they were asking of was unfeasible.

But, then, you learnt and did not do it again. (I hope) And that is the most important part :)

Collapse
 
kallmanation profile image
Nathan Kallman

Thanks for the story!

It's "your" fault in the same way its the passenger's fault that was put in the cockpit asked to land the plane when it eventually crashes (oh by the way you can't use the radio or gps, have fun!).

Or said another way, its not your fault at all. Why did anyone put you in that position? Glad you were able to get out of it!

Collapse
 
enyichiaagu profile image
Amazing Enyichi Agu

Wow. 👏👏👏👏
Totally enjoyed the story