@molly_struve caught this one in a recent pull request of mine.
The obvious question here is.... Should I be using
git commit --amend or another history rewriting technique to clean this up?
I know I can, and maybe I should, but I've never developed the habit of using this technique and generally never thought of it as a big problem in most cases, but I'm wondering if other folks feel differently bout the harm of not cleaning up extra commits like this.
All around I could have been clearer with the commit messages, but also, contextually it was somewhat clear. It was me trying a few things and committing the code to see if it worked with our continuous integration.
Feedback is definitely welcome here!