What was your first PR on Github?

#github #discuss #programming

What was your first PR on Github and what can you tell about it? Mine was:

Oh yes I remember that one...! Silly times!

Top comments (25)

Basile B. • Sep 19 '18

I can't remember what i did with a previous account (deleted since) but with the one i currently use it was some annotations in D standard library, allowing to use some allocators in what we call nogc code.

Jo Cook • Sep 19 '18 • Edited

I added a rude placename to the "Vaguely rude placenames" map at maps.geotastic.org/vaguely-rude-pl...!

Andrew Durber • Sep 19 '18

Added support for custom data-attributes in Bootstrap Multiselect: github.com/davidstutz/bootstrap-mu...

Then closed it shortly after because I didn't understand upstream sources, then created a new PR with a clean fork. Good times 😂

Andžs • Sep 19 '18 • Edited

Improvement on some jQuery plugin 4 years ago, but it was never merged 😞

As appears, that plugin was abandoned somewhere on around year.

John Bull • Sep 19 '18

My first PR was pretty ridiculous. I just added alt tags and labels to all the images on a website for an open source project. Funny thing was that the first pr for some reason messed up and didn't have like more than half of the code for the project. At least I realized my mistake and quickly canceled my first PR and re-did it correctly. To Say I was humbled was an understatement.

Benny Powers 🇮🇱🇨🇦 • Sep 18 '18

A little community localization. Good times.

Patrick Ziegler • Sep 19 '18

I fixed some bugs in a minecraft mod. They were things, I had struggled with myself and it was nice to be able to put that knowledge into good use.

Bohdan Stupak • Sep 19 '18

Mine was typescript type definitions for jquery.nicescroll which I've added a couple of months ago. On my work front-end, I've started a migration to typescript (I promise to deliver an article about it one day) and I've needed those type definitions badly so I've decided to try myself as open source contributor.

Elan Utta • Sep 23 '18

my frist Pull Request was in my friend's repository, we are building a website that makes recommendation of streamers, it was difficult to write the code, but it finally came out.