Andy Zhao (he/him) for The DEV Team

Posted on Jun 25, 2019

dev.to Repo Recap from the Past Week

#changelog #meta #opensource #reporecap

Welcome back to another Repo Recap, where we cover last week's contributions to dev.to's repository the iOS repo, and the Android repo. This edition is covering June 15 to June 21.

Main Repo

Features

@ben added subtitles for iOS push notifications. Thanks, Ben!

Add subtitle to ios push notification #3170

benhalpern posted on Jun 15, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

Make use of full space on ios notifications

View on GitHub

We now have a polls feature (in closed beta)! Read more about it in Ben's post:

Feedback on this new DEV feature?

Ben Halpern for The DEV Team ・ Jun 15 '19

#meta #changelog

Beta polls feature (admin use only for now) #3176

benhalpern posted on Jun 15, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

This PR includes some basic functionality for including polls in tweets. It limits so that only admins can include polls because I think there are more complexities around polls we want to nail down, along the lines of:

An article with a poll probably shouldn't allow edits because that could compromise the poll.
A poll should only be able to be embedded in a single article as to keep context consistent.
This means more "awareness" of the context from the liquid tag perspective.
A poll should be definable through some fairly straightforward UI which begs questions of when a poll gets "saved".

So for now I made it so that it's more of a conceptual feature for now that we can use internally but it will be fun to show off until we answer the rest of the questions.

Forgive my silly placeholder text:

View on GitHub

@ben added minimal light theme! You can turn it on in your settings. Thanks, Ben!

Add minimal light theme #3179

benhalpern posted on Jun 16, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

Add new theme "minimal light" which includes more overall white and minimalism compared with the default theme.

Also tossed in some adjustments to the html_variants backend.

View on GitHub

Thanks to @tvanblargan, DEV post embeds/Liquid tags now have the publish date.
Add Date to Link Liquid Tag #3126
12vanblart posted on Jun 11, 2019
What type of PR is this? (check all applicable)
- [ ] Refactor
- [x] Feature
- [ ] Bug Fix
- [ ] Documentation Update
Description

I noticed an inconsistency where the publish date was not included in liquid links to dev posts.

Disclaimer: I'm not familiar with ruby at all and was struggling to get it working to run the tests (Windows 10 - locked out of installing WSL). I was also unable to get the liquid tags working in Gitpod (Twitter thread with possibly helpful info).

Related Tickets & Documents

n/a

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

n/a (See above comments about Gitpod)

Added to documentation?
- [ ] docs.dev.to
- [ ] readme
- [x] no documentation needed
View on GitHub
There's now an organization Liquid tag for embedding your organization! Thanks, @ben!

Add organization liquid tag #3203

benhalpern posted on Jun 17, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

View on GitHub

@claramorgen updated the timestamp on notifications to show a post's publish date as opposed to when the notification was created. Thanks, @claramorgen!

Update timestamp on notifications #3076

claracodes posted on Jun 08, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

I changed the timestamp in notificatios to when the comment/article was created. Before it showed the timestamp of when the notification was created, which was confusing. I changed it for articles and comments, all the other notifiables didn't have timestaps.

Related Tickets & Documents

Fixes #2997

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

View on GitHub

There is now a listings dashboard for you to easily manage your listings. Thanks, @mariocsee!

Listings Dashboard #3014

mariocsee posted on May 31, 2019

What type of PR is this? (check all applicable)

[x] Feature

Description

A dashboard for users to manage their listings:

see all their listings (info: organization, title, date, category tags | actions: edit )
show number of listings, create listing button, number of credits for logged in user (and the orgs they are in), buy credits button
displayed information adjusts to which organization or user is selected

Future PRs:

Sorting listings by creation/bump date
Visual indication of expired listings
Directly bump or delete listings from within Dashboard rather than having to go into the Edit page
Analytics
Reflect expired state of listings in editing so it's clear when to re-publish/bump.
Testing for the entire Preact listings side

Related Tickets & Documents

#2825

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

[x] no documentation needed

View on GitHub

@rhymes added a new history feature for pro members (a currently closed beta program). Check out the PR for the details. Thanks, @rhymes!

Pro: History #3220

rhymes posted on Jun 18, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

With this PR we introduce a new feature only available to pro users: the history.

The feature borrows a lot from the reading list, maybe in the future we could refactor both to share more code (both in the CSS which is nearly identical, the JS and the Ruby code). I don't think this PR should do that right away.

Index

As for the reading list we're using Algolia for indexing. The index is built by instances of the PageView (only those of pro users are added to the index):

This is the index's definition:

  algoliasearch index_name: "UserHistory", per_environment: true, if: :belongs_to_pro_user? do
    attributes :referrer, :time_tracked_in_seconds, :user_agent, :article_tags

    attribute(:article_title) { article.title }
    attribute(:article_path) { article.path }
    attribute(:article_reading_time) { article.reading_time }
    attribute(:viewable_by) { user_id }
    attribute(:visited_at_timestamp) { created_at.to_i }

    attribute :article_user do
      # ...
    end

    attribute :readable_visited_at do
      # ...
    end

    searchableAttributes(
      %i[referrer user_agent article_title article_searchable_tags article_searchable_text],
    )

    tags { article_tags }

    attributesForFaceting ["filterOnly(viewable_by)"]

    customRanking ["desc(visited_at_timestamp)"]
  end

Basically we index the referrer (currently unused), the time tracked (currently unused), the user agen (currently unused), some properties for the article (tags, title, path, reading time, user). We also index a readable date shown (which is not the time the article was published like in the reading list but the time the user visited such article).

We also allow the user to search on article's tags, title and body excerpt. The searchable index currently contains the referrer and the user agent as well BUT I'm not sure those should be "silently" searchable, without a better UI (or a visible facet?).

Everything is then ranked by descending timestamp, so that the new visits will appear at the top

Pagination

This PR contains pagination for the results, see screenshots below

Open questions / issues

should we add referrer, time tracked and user agent if we don't show them? If we do want to show them, what's the best way to do it?
should the user be able to search on referrer and user agent "silently" ?
what else we should add to the single item in the UI?
Page views can be repeated, in the sense that if I visit an article twice in a row, I'll see two entries. Is that ok? See example:

should we put the link to the history page in the homepage?

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

How it looks

Pagination and search demo

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

View on GitHub

@rhymes added a "stats" button in the dashboard for pro members. Thanks again, @rhymes!

Add article pro stats button in dashboard #3230

rhymes posted on Jun 19, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

Shows the stats button in the article's dashboard if the current user is a pro user

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

View on GitHub

@jess added an internal feature to mark something as Buffered. Thanks, Jess!

add buffered checkbox to individual articles #3238

jessleenyc posted on Jun 19, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

Gives admin the option to mark an article as buffered even if it didn't go through the usual buffer flow.

View on GitHub

@bellsenawat added a "load more" button for the reading list. Thanks, @bellensenawat!

Feature/reading list loadmore button #3221

bellsenawat posted on Jun 18, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

A load more button will show when reading list is array length more than 64 and it will hide when no reading list to load from API.

Related Tickets & Documents

#3122

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

View on GitHub

Bug Fixes / Other Contributions

@mazentouati add a possible error solution for the Windows installation of the dev.to repo. Thanks, @mazentouati!

Add a possible error resolution for windows installation #3178

sunchayn posted on Jun 16, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[x] Documentation Update

Description

I faced an undocumented error during the installation of DEV : ERROR: Error installing pg. This PR adds the required resolution for that.

Added to documentation?

[x] docs.dev.to
[ ] readme
[ ] no documentation needed

View on GitHub

@rhymes removed an extraneous presence validator for the PollVote model. Thanks, @rhymes!

Remove double presence validator in PollVote #3187

rhymes posted on Jun 17, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Documentation Update

Description

There's a double presence: true validator in PollVote

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

View on GitHub

@rhymes added a development setting that warns if too many records are being loaded. Thanks again, @rhymes!

Add warn_on_records_fetched_greater_than setting in development [skip ci] #3182

rhymes posted on Jun 16, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Documentation Update

Description

This should help keeping an eye on the cases where too many records are accidentally loaded in a single query. The comment has been taken from https://guides.rubyonrails.org/configuring.html

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

View on GitHub

@briwa fixed how the <hr> tag looks in the dark theme. Thanks, @briwa!

fix(article): `<hr>` should be visible in night theme #3202

briwa posted on Jun 17, 2019

What type of PR is this? (check all applicable)

[x] Bug Fix

Description

I just tried out night mode today (I know, I'm slow... 😋) and I realized that <hr/> elements are not that visible:

A little comparison with the default/minimal light/pink theme:

Proposal

I am proposing to change it to something like this:

So that it reflects night theme. It should not change anything on the default/minimal light/pink theme tho, since it isn't contrast to the background.

I'm not quite sure if what I'm doing with the themeable is correct, so let me know. Also if there's a better color suggestion. Thank you.

Related Tickets & Documents

None

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

None

Added to documentation?

[x] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

View on GitHub

@mazentouati fixed some typos in our Dockerfile. Thanks, @mazentouati!

Fix some typos in Dockerfile comments #3214

sunchayn posted on Jun 17, 2019

What type of PR is this? (check all applicable)

[x] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

Fix some typos in Dockerfile comments

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

View on GitHub

@lightalloy fixed an issue where Slack messages were being sent to the wrong channel name. Thanks, Anna!

Updated slack channel name #3218

lightalloy posted on Jun 18, 2019

What type of PR is this? (check all applicable)

[x] Bug Fix

Description

The slack channel warned-user-activity was renamed to warned-user-comments but not in the code, so the SlackBot was unable to send messages to the channel which causes errors The slack API returned an error: channel_not_found (HTTP Code 404)

View on GitHub

@lightalloy also fixed an mishandled condition where the Twitch webhook was returning empty data. Thanks again, Anna!

Don't try to register webhook when twitch returns empty data #3219

lightalloy posted on Jun 18, 2019

What type of PR is this? (check all applicable)

[x] Bug Fix

Description

I had fixed the error when twitch returns no data earlier in #2865 Sometimes twitch returns empty data, we should handle this situation as well.

Related Tickets & Documents

#2784 #2865

View on GitHub

@mazentouati fixed an issue where Stack Overflow sub-communities were not being allowed in the Stack Overflow profile URL. Thanks, @mazentouati!

Allow stackoverflow sub communities profiles #3215

sunchayn posted on Jun 18, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Documentation Update

Description

Stack overflow has 4 sub communities: Spanish, Russian, Japanese and Portuguese. This PR will make it possible to link a profile in one of these communities as well.

Related Tickets & Documents

Fix #3204

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

View on GitHub

@lightalloy fixed a validation for the Mention model when validating an empty instance. Thanks, Anna!

Fix mention validation when validating an empty instance #3188

lightalloy posted on Jun 17, 2019

What type of PR is this? (check all applicable)

[x] Bug Fix

Description

fixed Mention.new.valid? failing on undefined method for Nilclass
creating a valid mention when using a factory

View on GitHub

@cyrillefr moved HtmlVariantSuccess.create DelayedJob calls to ActiveJob. Thanks, @cyrillefr!

Move HtmlVariantSuccess.create delay calls to ActiveJob #3173

cyrillefr posted on Jun 15, 2019

add AJ job + job spec
refactor call

What type of PR is this? (check all applicable)

[x] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

Move HtmlVariantSuccess.create delay calls to ActiveJob

Related Tickets & Documents

#3136

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

View on GitHub

@rhymes made some optimizations to the listings dashboard. Thanks, @rhymes!

Dashboard listings: optimized queries #3233

rhymes posted on Jun 19, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Documentation Update

Description

Right now we're calling the same query twice when we could just call it once and even avoid creating Ruby objects that get instantly discarded

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

View on GitHub

@rhymes fixed a bug where organization post's could not display stats properly. Thanks again, @rhymes!

Display stats for organization article #3232

rhymes posted on Jun 19, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Documentation Update

Description

There was a bug where the frontend was not passing the organization id to the backend, and thus the fetching of the stats failed for organization articles.

This also adds a bit of error handling for fetch API

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

View on GitHub

@ben updated a hardcoded image to use the relative path from Rails' Asset Pipeline instead. Thanks, Ben!

Remove hardcoded image from chat channel images #3235

benhalpern posted on Jun 19, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Documentation Update

Description

Switch out hardcoded image for dynamic reference of file

View on GitHub

@jess added the listings logo for a listing's OpenGraph social card. Thanks, Jess!

Add missing listings logo for social card #3237

jessleenyc posted on Jun 19, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Documentation Update

Description

Missed a file last week, this adds the listings logo to listings social cards.

View on GitHub

@mariocsee fixed an issue when managing listings as an organization admin. Thanks, Mario!

Manage listings as organization admin #3228

mariocsee posted on Jun 18, 2019

What type of PR is this? (check all applicable)

[x] Bug Fix

Description

In the newly pushed Listing Dashboard (see PR below), if you are an admin of one or more orgs, you will see all listings under those organizations. It shows the edit button for each listing as well, but when you click edit, it leads to an error because authorization was limited to users with the same user_id in the listing and doesn't account for org_admins wanting to edit a listing.

This PR adds validation for org_admins for organization_id in the appropriate listings.

Related Tickets & Documents

#3014 Listing Dashboard PR

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

N/A

Added to documentation?

[x] no documentation needed

View on GitHub

@maestromac updated the Windows installation documentation for statement_timeout errors. Thanks, Mac!

Update doc on statement_timeout errors #3248

maestromac posted on Jun 20, 2019

What type of PR is this? (check all applicable)

[x] Documentation Update

Related Tickets & Documents

https://github.com/thepracticaldev/dev.to/issues/3180

Added to documentation?

[x] docs.dev.to

View on GitHub

@maestromac also updated RssReader to properly handle Liquid and YouTube tags. Thanks again, Mac!

Update RssReader's liquid & youtube parsing logic #3229

maestromac posted on Jun 18, 2019

What type of PR is this? (check all applicable)

[x] Bug Fix

Description

Pre-escape {{ }} expression that is breaking MarkdownParser with backtick.
Loosen up RssReader's youtube id parsing logic.

Related Tickets & Documents

https://github.com/thepracticaldev/dev.to/issues/3070

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

[x] no documentation needed

View on GitHub

I fixed a bug where deleting a comment would still allow the comment's title attribute to be visible.

Delete a comment's title if it is deleted #3249

Zhao-Andy posted on Jun 20, 2019

What type of PR is this? (check all applicable)

[x] Bug Fix

Description

This adds fixes a bug where a comment's title attribute returns some of the comment's text even if it is deleted.

Also fixes a small bug for notification cards where the whole notification card <div> showed the pointer cursor.

View on GitHub

@cyrillefr moved HtmlVariantTrial.create DelayedJob calls to ActiveJob. Thanks, @cyrillefr!

Move HtmlVariantTrial.create delay calls to ActiveJob (#3173) #3239

cyrillefr posted on Jun 19, 2019

- add AJ job + job spec
- refactor call

What type of PR is this? (check all applicable)

[x] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

Move HtmlVariantTrial.create delay calls to ActiveJob

Related Tickets & Documents

#3136

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

View on GitHub

@ben fixed some logic and adjusted the copy for rewarding tag badges. Thanks, Ben!

Fix logic and adjust copy for tag rewarding #3251

benhalpern posted on Jun 20, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Documentation Update

Description

Fix bug where tag badge rewarder wasn't accounting for only past week articles

View on GitHub

@lightalloy fixed some Rubocop (a Ruby/Rails linter) issues and create a new .rubocop_todo.yml. Thanks, Anna!

Fixed rubocop issues, new .rubocop_todo.yml #3255

lightalloy posted on Jun 21, 2019

What type of PR is this? (check all applicable)

[x] Refactor

Description

fixed new rubocop issues
generated a new .rubocop_todo.yml

View on GitHub

@rhymes removed some dead code for the now deprecated mentoring feature. Thanks, @rhymes!

Remove code for legacy mentoring feature #3186

rhymes posted on Jun 17, 2019

What type of PR is this? (check all applicable)

[x] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

This removes the "legacy" mentoring feature code. It also removes columns in the users table and the mentor_relationships table.

Added to documentation?

[ ] docs.dev.to
[ ] readme
[x] no documentation needed

View on GitHub

New Issues and Discussions

@kensixx requested a feature where the "Follow Back" button is shown in the follower dashboard. Thanks, @kensixx!

"Follow Back" button on each of Followers in the list IF you are not followed to them yet #3169

kensixx posted on Jun 15, 2019

Is your feature request related to a problem? Please describe.

I just noticed that when you view your Followers list, currently there's no "Follow Back" option next to the follower's name.

Currently you would have to click the profile of the follower, then that's the time you can follow him/her back.

Describe the solution you'd like

It would be nice if there's a "Follow Back" button next to the follower's name, or at the far right of each div (if it's a div) if you're not currently followed to him/her yet. This makes following back more quicker and more nicer, to me I guess =)

And if you're already followed to him / her, a "Followed" icon would show up I suppose. =)

Added an image to show what I currently have in mind, I added blue squares at the end of each follower =)

View on GitHub

@jsjoeio requested a feature to turn off notifications for people they follow.Thanks, @jsjoeio!

Feature request: Turn Off Notifications for People I Follow #3171

jsjoeio posted on Jun 15, 2019

Is your feature request related to a problem? Please describe.

I'm frustrated when I see notifications that are related to people I follow creating a new post.

Describe the solution you'd like

I'd love to be able to turn off notifications so that I am not notified when people I follow create a new post.

I'm not sure the best way to solve this but could be nice to have two options:

Turn off all notifications for posts by people I follow
Have a list of people I follow, and be able to selectively choose which people I want to be notified of their new posts.

This way, I only receive notifications when people interact with my posts. Describe alternatives you've considered

Current workarounds:

Don't follow anyone
Don't open notifications

(okay these are meant to be funny, but I don't see any real alternatives yet).

Additional context

I don't have time to work on it myself (or experience, no Ruby exp for me yet).

Other people on Twitter seem to agree this would be nice.

View on GitHub

@bhupesh requested a feature: <meta> tags that include a post's tags. Thanks, @bhupesh!

Addition of dev.to tags in meta tag #3181

Bhupesh-V posted on Jun 16, 2019

Additional context

Including article:tag in the meta information will be a good idea for SEO I have seen that dev.to has already a og:type tag.

<meta property="og:type" content="article">

So adding to this could be a good idea. freecodecamp also has a article:tag

<meta property="article:tag" content="Angular">

Taking it further article:author could also be added.

View on GitHub

@avalander requested a feature where the editor could show a tag's guidelines. Thanks, @avalander!

Feature request: List added tag guidelines in the editor #3216

Avalander posted on Jun 18, 2019

Is your feature request related to a problem? Please describe. Not really a problem, but I've noticed that some tags get misused a lot. Especially the discuss tag seems to be used as a wildcard for all sorts of topics. Since the guidelines are only visible in the tag page, I suspect a lot of users don't even know that they exist.

Describe the solution you'd like Maybe it would be good to display the guidelines for the tags added to the post in the editor view, with a warning that tags not adhering to the guidelines may be removed.

Describe alternatives you've considered

Additional context

View on GitHub

@rugk requested a feature to automatically enable/disable dark mode via a browser's prefers-color-scheme setting. Thanks, @rugk!

Automatically enable/disable dark mode via prefers-color-scheme #3222

rugk posted on Jun 18, 2019

Is your feature request related to a problem? Please describe.

There is a manual switch for a dark mode, but that is inconvenient and I would have to do that on each site if each site were doing it like this.

Describe the solution you'd like

There is a quite new CSS media query feature called prefers-color-scheme. It allows you to detect whether the system/user wants a dark website, so you can adjust your CSS.

Currently it is only supported by Safari and Firefox 67 or higher.

Anyway, it would be great, if you could make use of this to automatically select the correct style.

Describe alternatives you've considered

Keep manual switch -> ugly. (Note: You can still keep it, so the user can overwrite it, but you can change the default.)

Additional context

BTW: I also have a Firefox add-on called “Dark Mode Website Switcher” (source code) that you can use to toggle this setting in Firefox directly – without needing to change the system option. Maybe that could be helpful.

View on GitHub

@karaluton requested a feature where members could put an Instagram link on their profiles. Thanks, @karaluton!

Instagram Link #3224

karaluton posted on Jun 18, 2019

I'd love to have an Instagram link added. There's a growing developer community on Instagram and it'd be nice to be able to link to Instagram from our dev.to profile.

View on GitHub

@taillogs reported an issue with the reaction notifications count. Thansk, @taillogs!

Reported "recent reactions" don't make sense #3225

rylandg posted on Jun 18, 2019

Describe the bug My notification window will sometimes say "90" people recently reacted, only to then see "70" people recently reacted a few minutes later. This is very confusing and doesn't add value to the experience.

To Reproduce Get a lot of reactions on a post. Watch updates in notification window.

Expected behavior I'm assuming this is implemented with a rolling window for the notification metrics. That's completely valid but maybe the notification window could show the timeframe of the recent reactions.

"70 people reacted in the last X minutes" OR just show total reactions!

Desktop (please complete the following information):

OS: OSX
Browser: Chrome

View on GitHub

@taillogs reported an issue where the image upload button disappears at certain screen widths. Thanks again, @taillogs!

Image upload elements get lost at certain browser scales #3226

rylandg posted on Jun 18, 2019

Describe the bug When the horizontal size of the Dev.to window is scaled down, the "image" buttons can get lost and the window must be resized to recover them.

To Reproduce

Edit a post.
Narrow your browser window horizontally while watching the image button in the editor pane
Wait until it disappears

Expected behavior Buttons don't go on spiritual journeys outside of the browser.

Screenshots Before

After

Desktop (please complete the following information):

OS: OSX
Browser: Chrome
Version: 74.0.3729.169

View on GitHub

@taillogs requested a feature to add more than 1 image at a time. Thanks again, @taillogs!

Add more than 1 image at a time #3227

rylandg posted on Jun 18, 2019

Is your feature request related to a problem? Please describe. You currently cannot add more than 1 image at a time. This amongst other issues with the image uploading process causes it to be incredibly tedious.

Describe the solution you'd like Allow me to upload all the images at once. Generate sequential uuids for the URI's so addressability isn't an issue.

View on GitHub

@georgecoldham reported a bug where notifications don't have an updated link if someone changes their username. Thanks, @georgecoldham!

Notifications don't update permalinks with name changes #3234

GeorgeColdham posted on Jun 19, 2019

Describe the bug When a notification is received, the link to the article/comment is using the same permalink as can be used to reference it. If a user changes their name this permalink is broken and leads to a 404 page.

To Reproduce

Generate a notification somehow
Change the username of the notification sender
Try following the link

Expected behavior The link should still work and lead to the Article or comment.

Screenshots Notification with url Following the notification Comment on article. NOTE: Username change Permalink url of comment after name change

Desktop (please complete the following information):

OS: Mac OS Mojave 10.14.5
Browser: Google Chrome
Version: 75

Suggestion My suggestion for a fix, would be to have accounts linked to a uniquely generated id, allowing the names to be changed independently of any permalinks. The username could redirect to the unique id version of the url.

View on GitHub

@peter requested a feature where we make links in comments have the attribute rel="nofollow". Thanks, Peter!

Make links in comments rel="nofollow" #3236

pkfrank posted on Jun 19, 2019

Is your feature request related to a problem? Please describe. Occasionally, spam users will join DEV in order to post articles/comments that are primarily designed for a backlink. We already have several mechanisms in place to proactively and reactively deal with this sort of abuse, but we can do more to specifically deter comment spam.

Describe the solution you'd like Make all links in comments rel="nofollow".

Additional context Per convo with team, this would mean adding rel="nofollow" to links when parsing the markdown in comments, but not in articles.

View on GitHub

@michaeltharrington reported an issue where HTML elements are not escaped in a notification's box area. Thanks, Michael!

HTML elements are not escaped in the activity view #3241

michael-tharrington posted on Jun 19, 2019

Describe the bug When posting an article like this on e- https://dev.to/rikschennink/ul-or-ol-do-you-know-when-to-choose-which-5cic which has HTML elements in the title, those will not be displayed properly on the notification page - https://dev.to/rikschennink/ul-or-ol-do-you-know-when-to-choose-which-5cic.

Expected behavior HTML elements should show up as text when placed in titles from all views on the site.

Screenshots

View on GitHub

@taillogs reported an issue where having a Code block as the first content in a post looks strange in the summary in the /comments view. Thanks, @taillogs!

Code block as first content in post causes preview to look bad #3242

rylandg posted on Jun 20, 2019

Describe the bug If your post begins with a code block, the preview shows it unformatted and without \n.

Oh and I noticed while posting this, that an image link in first part of a post also doesn't transfer to preview.

To Reproduce Example post

```
// caller
function foo(callback) {
  callback('world');
}

// callback function
function myCallback(name) {
  console.log(`Hello ${name}`); // "hello world"
}

// pass callback to caller
foo(myCallback);
```

Create a draft and look at the preview

Expected behavior Just remove the preview for now. Maybe something clever as backlog.

Screenshots

Desktop (please complete the following information):

OS: OSX
Browser: Chrome

View on GitHub

@emma requested a feature to turn off reaction notifications for specific posts. Thanks, @emma!

Turn off notifications for hearts #3244

emgoto posted on Jun 20, 2019

Is your feature request related to a problem? Please describe. I would like to turn off being notified (by the number icon in the top right corner) when I have received a heart/like on a comment or article.

Describe the solution you'd like

When you go to the notification settings page, there's a checkbox option to turn off receiving notifications for hearts / likes. Ideally I'd like to be notified when someone comments / replies to a comment but nothing else.

View on GitHub

@drewswaycool requested a feature to exclude tags

Ability to exclude tags #3246

drewswaycool posted on Jun 20, 2019

I want to be able to see all #react tag posts, but not include #react #redux posts.

It would be nice to always exclude posts based on tags you don't want to see.

View on GitHub

@michaeltharrington requested a feature to allow people to temporarily hide their accounts, or go in a vacation mode. Thanks, Michael!

Give Users the Ability to Temporarily Hide Their Accounts (Vacation Mode) #3252

michael-tharrington posted on Jun 20, 2019

Is your feature request related to a problem? Please describe.

Users occasionally want the ability to temporarily hide / deactivate their account so that they're able to keep their content and history on DEV but if need be can take a break due to work/other online commitments.

Describe the solution you'd like

Perhaps a user could turn on "vacation" mode so that their account is out of view. During this mode:

the user wouldn't be able to comment/use reactions/write posts/make listings/message over Connect (maybe other actions?)
their writing, profile, and comments wouldn't be visible. (anything that would identifying activity)
they could still be logged in to view their feed, add items to their reading list,change things about their profile while it's out of view, etc.
notifications would still be controlled under their own setting

Describe alternatives you've considered I considered a similar idea to the above where the user would have to completely be logged out during their vacation.

Additional context Right now, when users have to delete their presence on the site for whatever reason, they can't get it back. They must create a fresh account.

View on GitHub

@ksato1995 reported a bug where having too much info in your profile will overflow and be cut off. Thanks, @ksato1995!

Profile overflowing issue #3253

K-Sato1995 posted on Jun 21, 2019

Describe the bug

When a user puts too much info in his/her profile, it gets covered up. It should be scrollable or something.

Kind of hard to explain with words but I think it's easy to understand what I'm trying to say from the screenshot.

To Reproduce

Check her profile

https://dev.to/mollynem

Expected behavior All the info should be readable.

Screenshots

Desktop (please complete the following information):

OS:
Browser:
Version:

Smartphone (please complete the following information):

Device:
OS:
Browser:
Version:

Additional context

View on GitHub

@gypsydave5 requested a feature for the RSS feed reader to follow links in order to fetch a post's content. Thanks, @gypsydave5!

RSS feed reader to follow links to fetch article #3254

gypsydave5 posted on Jun 21, 2019

Is your feature request related to a problem? Please describe. My blog's RSS feed (https://blog.gypsydave5.com/feeds/feed.rss) does not publish the blogs content to each item in the feed. I'm under the impression that this is what's needed to publish to dev.to via RSS.

Describe the solution you'd like I'd like the dev.to RSS reader to make an HTTP request to the <link> in each <item> to fetch the article, parse it, then extract the HTML around the <article> tag (which seems like the appropriate tag). The reader should revert to previous behaviour should any of this fail.

Describe alternatives you've considered I could start putting the content in a <content> tag, but I feel this is wrong because

it's not in the RSS spec
there's already link to the content in the RSS item
it would unnecessarily increase the size of the feed.

Context I'm happy to work on this, but my Ruby is rusty.

(my Rust, however, is not ruby-y... 😜)

View on GitHub

@tducasse reported an issue wher ethe reading time estimate is inconsistent across pages, namely the post itself and search results including the post. Thanks, @tducasse!

Reading time estimate is inconsistent across pages #3257

tducasse posted on Jun 21, 2019

Describe the bug

The time estimate is not the same in the search results and if you go to the article.

I think some of them are right? I'd say the one in the search results seems smaller.

To Reproduce Either:

click here
and here

Or:

go to the search bar
type something
choose an article, read the time estimate
click on the article, check the estimate

Expected behavior

Both estimates should be the same.

Screenshots

Desktop (please complete the following information):

OS: Mac OS Mojave 10.14.5
Browser: Chrome
Version: 75.0.3770.100

View on GitHub

@stargator reported an issue where the notification page does not show all notifications. For anyone wondering, we currently don't paginate notifications. More details in the issue. Thanks, @stargator!

Notifications Page needs pagination #3259

Stargator posted on Jun 21, 2019

Describe the bug I saw I had 138 notifications, I went to the page, but it only listed 53 items on the page and offered no way to see the other unseen notifications.

Additionally, the notifications that I did not see have been marked as seen once I went to the Notification page.

The issues are:

Not all notifications are displayed.
Notifications not displayed are marked as seen.

To Reproduce

Do not go to your Notification page until you have over 53 notifications. So 55-60 should suffice.
Click on Notification Icon from Home page
Count the number of notifications on the page, should max out to 53 items.
Go back to the home page and note that it no longer shows 55-60 notifications even though you only saw 53.

Expected behavior I would expect notifications not the marked as seen until they each appear in the active view of the browser. So when the Notifications page renders, only the initial notifications seen in the first view should be marked as seen.

Additionally, I expect that I can scroll down or page over to view all my notifications.

Screenshots

Desktop (please complete the following information):

OS: Mac 10.14.5
Browser: Chrome
Version: 75.0.3770.100

View on GitHub

@markel reported an issue where Glitch previews were not working properly. Thanks, @markel!

Unexpected error on Glitch previews #3261

MarkelFe posted on Jun 21, 2019

Describe the bug Glitch returns the error

Unknown: Server error. An unexpected error has occurred.

when loading various Glitch iframes (based on the little testing I was able to done)

To Reproduce

Go to this article or any article including multiple glitch iframes
Done, the error should appear

Expected behavior While the iframe loads correctly if you press "Try again" it should load correctly the first time.

Screenshots

Desktop (please complete the following information):

OS:
Browser:
Version:

Smartphone (please complete the following information):

Device: PocoPhone F1
OS: Android 9 (Flavour: LineageOS)
Browser: Google Chrome PWA
Version: 75

Additional context

I haven't been able to test what happens if you load a single Glitch iframe.
I haven't investigated the Response Code Glitch provides as I'm in mobile. Knowing it could help.
It's probably a system to avoid bots to overload the Glitch website.

View on GitHub

DEV-iOS

We haven't had much activity this week on the iOS repo. Feel free to make an issue, look at the codebase, or make a pull request!

DEV-Android

Features

@sierisimo moved code to JDK8. More details in the PR. Thanks, @sierisimo!

Moving code into JDK8 #40

sierisimo posted on Jun 19, 2019

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Documentation Update

Description

I'm trying to contribute to the project, my first thing to give is an update to the libs in the project, we can move into JDK8 for kotlin and the compilation rules. This is mostly a suggestion given some libraries will throw errors if not compiling with JDK8.

Also…

Moved in data/build.gradle the order of plugins applied (it throws an error or a warning depending on configurations) for kotlin. The warning/error states that kotlin-android should come before `kotlin-android-extensions
Updated the versions of libraries:
- androidx.test:runner --> 1.1.1 -> 1.2.0
- androidx.test.espresso:espresso-core --> 3.1.1 -> 3.2.0