GitHub draft PRs are here!

twitter logo github logo ・1 min read

Photo by EJ Yao on Unsplash

Gone or soon to be gone are the days of creating a PR and marking it as WIP or DON'T MERGE!

For galentine's, GitHub has given us Draft PRs

Happy Galentine's

I think it's great. What are your thoughts on draft PRs?

SNL Coffee Talk

twitter logo DISCUSS (17)
markdown guide
 
 

A great thing about this is that you can set them up so that they don't ping the reviewers until the PR is ready:

Also, if you have a CODEOWNERS file in your repository, a draft pull request will suppress notifications to those reviewers until it is marked as ready for review.

from github.blog/2019-02-14-introducing...

 

Seems interesting; my group tends to do something like mark a PR as incomplete with a WIP in the title so this could be a more "formal" version of that.

 

That's currently what we do, too. We use that together with the WIP Probot. Maybe we'll switch to drafts though?

 

I'd expect that, yeah. Drafts seem to fit with that workflow.

 
 

That's pretty rad! I didn't know they were working on this.

 

Is there any way to change normal PR to draft PR after creating the PR?

 

Not yet. See this thread.

 

Hasn't gitlab supported this for a while now? IIRC it actually has a checkbox for WIP pull requests and warns you before trying to merge one, lets you filter by WIP, etc.

 

It has. There's a checkbox that adds WIP: to the PR title and prevent merging it until you remove it from the title.

 

Nice to see more gitlab features coming to github ;P

 

I like it, but I do not understand why you should even open a pull request before you are ready to merge changes.

 

ooh, I have lots of thoughts on this! πŸ˜ƒ

I like to do it as a way to get feedback on code before it's ready.

I'll open a draft PR, then my teammates can comment on specific lines of code. The entire discussion stays in one thread.

For larger changes, I've also used it as a way to communicate progress. I'll open a draft PR, and then write out a check list showing what's done and what isn't. Then anyone following along is able to see where I'm at with the project. πŸ˜ƒ

 

I see - you mean if you have some changes you want to be reviewed but you do not want it to be merged because you aren't done yet.

 

I have been waiting for this!!! I have never been a fan of WIP PRs bc I think they can distract from those PRs that actually need to get merged and pushed out.

 

Hmm I actually prefer the way Gitlab does it ... (If WIP is in the name, automatically consider it Draft)
You cannot convert normal PR yet... It's rather hard to notice the option itself ...

Classic DEV Post from Oct 22 '18

Who's looking for open source contributors? (October 22nd edition)

We're towards the end of #hacktoberfest! Find something to work on or promote ...

Nick Taylor profile image
Just some dev on the Shotgun team #TypeScript #reactjs #JavaScript #nodejs, c#/asp.net once upon a time.