A great thing about this is that you can set them up so that they don't ping the reviewers until the PR is ready:
Also, if you have a CODEOWNERS file in your repository, a draft pull request will suppress notifications to those reviewers until it is marked as ready for review.
Coding is as much a matter of personal growth as it is of logic and control-flow. I keep patience, curiosity, & exuberance in the same toolbox as vim and git.
*Opinions posted are my own*
I have been waiting for this!!! I have never been a fan of WIP PRs bc I think they can distract from those PRs that actually need to get merged and pushed out.
I like to do it as a way to get feedback on code before it's ready.
I'll open a draft PR, then my teammates can comment on specific lines of code. The entire discussion stays in one thread.
For larger changes, I've also used it as a way to communicate progress. I'll open a draft PR, and then write out a check list showing what's done and what isn't. Then anyone following along is able to see where I'm at with the project. 😃
Hasn't gitlab supported this for a while now? IIRC it actually has a checkbox for WIP pull requests and warns you before trying to merge one, lets you filter by WIP, etc.
A 'driven' software engineer with a passion for cars and tabletop games. Get it, driven? Because cars and... Okay, I'll stick to writing code instead of puns. 🏁
Top comments (16)
Cool, love this!
A great thing about this is that you can set them up so that they don't ping the reviewers until the PR is ready:
from github.blog/2019-02-14-introducing...
Nice to see more gitlab features coming to github ;P
Farewell 'NOTE: DO NOT MERGE' 😂
app.js
import React, { useState } from 'react';
import './App.css';
import "bootstrap/dist/css/bootstrap.min.css";
import AddNote from './components/addNote';
import NoteCard from './components/noteCard';
function App() {
const [noteCount, setNoteCount] = useState(localStorage.getItem('noteObjCount') || 0);
const addNote = () => {
setNoteCount(parseInt(noteCount)+1);
};
const deleteNote = (count) => {
setNoteCount(count);
};
return (
);
}
I have been waiting for this!!! I have never been a fan of WIP PRs bc I think they can distract from those PRs that actually need to get merged and pushed out.
Is there any way to change normal PR to draft PR after creating the PR?
Not yet. See this thread.
I like it, but I do not understand why you should even open a pull request before you are ready to merge changes.
ooh, I have lots of thoughts on this! 😃
I like to do it as a way to get feedback on code before it's ready.
I'll open a draft PR, then my teammates can comment on specific lines of code. The entire discussion stays in one thread.
For larger changes, I've also used it as a way to communicate progress. I'll open a draft PR, and then write out a check list showing what's done and what isn't. Then anyone following along is able to see where I'm at with the project. 😃
I see - you mean if you have some changes you want to be reviewed but you do not want it to be merged because you aren't done yet.
Hasn't gitlab supported this for a while now? IIRC it actually has a checkbox for WIP pull requests and warns you before trying to merge one, lets you filter by WIP, etc.
It has. There's a checkbox that adds
WIP:to the PR title and prevent merging it until you remove it from the title.That's pretty rad! I didn't know they were working on this.
That's currently what we do, too. We use that together with the WIP Probot. Maybe we'll switch to drafts though?