Welcome back to another Repo Recap, where we cover last week's contributions to dev.to's repository and the iOS repo. This edition is covering February 3 to February 9.
Features
-
@ben made quite a few performance improvements. Check them out below:
-
@link2twenty added another CSS variable --theme-container-color as part of his continued dark theme efforts. Thanks, Andrew!
-
@rhymes added the
titleattribute to badge images. Thanks, @rhymes! -
@rhymes made the PR to upgrade our Ruby version to 2.6.1. Thanks again, @rhymes!
Bug Fixes / Other Contributions
-
@maestromac refactored our tests, and made our tests pass more reliably.
-
@jpachitas resolved a small bug where posts with gists pulled from a Medium RSS feed would sometimes fail. Thanks, @jpachitas!
-
@rhymes removed a duplicate husky configuration. Husky is a tool we use to check files before it is committed. Thanks, @rhymes!
-
@glennmen added the algorithm to reward the 3 year anniversary badge automatically. Thanks, @glennmen!
-
@aligoren fixed a small CSS issue where the "EDIT POST" button was too close to the profile image. Thanks, @aligoren!
-
@vaidehijoshi fixed our Skylight badge so it points to the now public URL! More details in our post below about how we use Skylight. Thanks, Vaidehi!
-
@rhymes updated our Rubocop configuration to match our Ruby version and use safe autocorrect in our pre-commit hook. Thanks, @rhymes!
-
We've updated our terms with a new content policy. Check it out in the terms page or the PR below. PR by @peter:
-
@ben made some optimizations to how we fetch new posts via RSS:
-
@ben also added two new timestamp columns to avoid an extra fetch:
profile_updated_atandgithub_repos_updated_at. PR below: -
@lightalloy fixed a bug that has been affecting our background jobs and memory usage, and started the process of moving our jobs into Rails' ActiveJob. Thanks, Anna!
-
@seanmfox fixed an issue where the v1 editor would not preview properly if you belonged to an organization and had not set any colors for your organization. The solution was to set default colors for organizations. Thanks, @seanmfox!
New Issues and Discussions
- @kayis reported a bug where the editor switched versions and deleted text. Not a fun bug indeed. ๐ Thanks, @kayis!
Editor switched versions and deleted text
#1733
Describe the bug
I wrote an article and pressed preview and suddenly had a new version of the editor, but the top half of my article was gone.
I had the impression this was some UI glitch and pressed save draft, but this just persisted the missing content.
It wasn't a long article and I just wrote it again, but it was kinda surprising behavior.
To Reproduce
I couldn't reproduce the issue, but this is what I did when it happened:
- Wrote a new article with the old editor
- Pressed did some previews and saves
- Pressed preview and got a new editor with missing content
Expected behavior
dev.to shouldn't switch editor mid-edit.
Desktop (please complete the following information):
- OS: Windows 7
- Browser: Firefox Quantum
- Version: 66.0b4 (64-bit)
Smartphone (please complete the following information):
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]
- @vorillaz requested a feature where we integrate Webmention. More details in the issue. Thanks, @vorillaz!
Add webmention integration.
#1736
Hello there, great work and I instantly fell in love with the community and your efforts. As a publisher myself to dev.to, I would love to have feedback on my content as it is cross-posted to dev.to.
It would be great if you could integrate webmention.io. It requires as little as adding a tag to the HTML head and authenticate your authority using your twitter account. Thanks in advance for your efforts :)
- @lightalloy reported a bug where nonexistent podcast episodes appear in the search results. Thanks, Anna!
Nonexistent podcast appears in the search results
#1741
Describe the bug The first podcast on the page returns 404.
To Reproduce Steps to reproduce the behavior:
- Go to the homepage
- Type "books" in the search input and submit
- Select "Podcasts" in the left menu.
- Click the first result (Episode 064 โ Favorite Programming Books), see "Not Found"
Screenshots
- @jess made an issue as a reminder to finalize the comment templates feature. Check out the latest post that uses it here:
- @peter reported a bug where the sidebar in mobile Android is able to scroll past the last section:
Key Links covering main feed on mobile
#1746
This is from an email into yo@ and the submitter has not provided additional info, so unfortunately we are light on details.
Describe the bug It appears that the Key Links area is covering the main feed.
To Reproduce Unclear. This appears to be an Android device. If anyone else is experiencing the issue, that will be really helpful.
Screenshots
- @sandordargo reported an issue where the number of views on his posts are not changing. Thanks, @sandordargo!
Number of views doesn't change
#1765
Hi,
I found something strange for my number of views.
I have the same number of views (user: @sandordargo, views: 156) for my last three posts.
The last one is strange, it hasn't changed for like two days, while the number of reactions are going up and it was featured on twitter as well. I don't think that the number of reactions can go up without the number of views also going up.
Thanks for having a look.
Cheers
- @qm3ster requested a feature where we don't convert SVGs with Cloudinary. There's a current discussion going (started by me) about how to sanitize an SVG. Thanks for the issue, @qm3ster! Leave any thoughts below:
Don't convert SVGs with Cloudinary
#1767
Is your feature request related to a problem? Please describe.
I used a vector svg image as a cover_image of a post today.
It got "optimized" by Cloudinary, and served with automatic format (f_auto).
This resulted in not only making it a 6.2KB webp (and even larger png) but also making it blurry.
The original image was 781 bytes on the wire.
Describe the solution you'd like If possible, we'd serve sanitized svgs.
Describe alternatives you've considered I suspect if I convert it to png myself it might be less blurry, I may try that later. (Also with white background instead of transparent, since that causes a gray background on DEV.to)
- @jeoxs reported an issue where the whole page lags when the sidebar(s) is/are opened. Check out the issue for an ongoing discussion. Thanks, @jeoxs!
Website lags when I open the sidebar (each one)
#1771
I recently wrote an article about this particular issue asking people if they had the same problem: https://dev.to/jeoxs/is-it-just-my-phone-or-devto-is-heavy--1h9l
The site starts freezing when I open a sidebar. I have a Samsung Galaxy S5 mini with Android 6.0.1 and latest Chrome and Android web view versions. At first I though it was my phone but others users have confirmed the issue on their devices, too.
Thank you in advance for your support :)
The last issue I'd like to include is an issue from the Weekly Digest Bot. For the most part, it's been a bit finicky and doesn't work all the time, but for three weeks it's been posting properly! It essentially creates an issue with a list of lots of everything that happened in our repo:
Weekly Digest (4 February, 2019 - 11 February, 2019)
#1783
![weekly-digest[bot] avatar](https://res.cloudinary.com/practicaldev/image/fetch/s--aSlbfvoN--/c_limit%2Cf_auto%2Cfl_progressive%2Cq_auto%2Cw_800/https://avatars0.githubusercontent.com/in/12517%3Fv%3D4)
Here's the Weekly Digest for thepracticaldev/dev.to:
ISSUES
Last week 53 issues were created. Of these, 30 issues have been closed and 23 issues are still open.
OPEN ISSUES
CLOSED ISSUES
LIKED ISSUE
NOISY ISSUE
PULL REQUESTS
Last week, 45 pull requests were created, updated or merged.
OPEN PULL REQUEST
Last week, 1 pull request was opened.
UPDATED PULL REQUEST
Last week, 12 pull requests were updated.
MERGED PULL REQUEST
Last week, 32 pull requests were merged.
COMMITS
Last week there were 32 commits.
-
Fix some of the linting](https://github.com/thepracticaldev/dev.to/commit/92b24a99788884ff616208c222340f6754b07ae6) by benhalpern
๐ ๏ธ [Fix ActiveRecord::RecordNotFound in Delayed::Jobs on article destroy (#1699) * fixedActiveRecord::NotFoundissue for articles, on article destroy -
extracted ActiveJobs from article callbacks
-
added specs for article and reaction deletions](https://github.com/thepracticaldev/dev.to/commit/7f6e0cf185a2c51cc2c1d3198d0f9c57a5602db3) by lightalloy
๐ ๏ธ [Make Spotify and generic Liquid tags more strict (#1759) * Add a few more liquid tags -
Update regex to be more strict](https://github.com/thepracticaldev/dev.to/commit/eec3fb87902dd93765a9c81afa157e71649601c2) by Zhao-Andy
๐ ๏ธ Fix profile cache issue (#1757) by benhalpern๐ ๏ธ Ping comments to pre-warm new comment trees (#1755) by benhalpern๐ ๏ธ Check for user exists in additional content box fetch (#1756) by benhalpern๐ ๏ธ [Add profile_updated_at and github_repos_updated_at to avoid extra fetโฆ (#1754) * Add profile_updated_at and github_repos_updated_at to avoid extra fetches -
Fix variant_number issue
-
Fix test](https://github.com/thepracticaldev/dev.to/commit/71a419e5eeff478855b9df12a12448f589d00d8b) by benhalpern
๐ ๏ธ [RSS feed optimizations (#1752) * RSS feed optimizations -
Update app/views/articles/feed.rss.builder
Co-Authored-By: benhalpern bendhalpern@gmail.com
-
Update app/controllers/articles_controller.rb
-
Update app/controllers/articles_controller.rb](https://github.com/thepracticaldev/dev.to/commit/7d6c85a29490cab49558ea03a5669eea2f0f458c) by benhalpern
๐ ๏ธ [Update DigitalOcean (#1753) - Updated DigitalOcean tagline/link
- On homepage and sponsors page](https://github.com/thepracticaldev/dev.to/commit/9c0bfd6cd06baec76462ddc951563f036fe60337) by pkfrank
๐ ๏ธ Update terms with content policy (#1751) - Added new "Content Policy" language by pkfrank๐ ๏ธ Update Rubocop configuration to target Ruby 2.6 and use safe autocorrect (#1713) [ci skip] by rhymes๐ ๏ธ Update Skylight badge to point to correct URL (#1680) Now that this app is running on open source in Skylight, the url that this badge links to is outdated. This commit updates the url to point to the public dashboard so that all dev.to contributors can view the open source performance data. by vaidehijoshi๐ ๏ธ [Improve performance for additional content boxes and tags index (#1750) * Improve performance for additional content boxes and tags index
- Modify followed_articles endpoint with new classic article api](https://github.com/thepracticaldev/dev.to/commit/2d97a5d83749861a2c36e73819d048104f8dda6c) by benhalpern
๐ ๏ธ [Upgrade Ruby to 2.6.1 (#1711) * Upgrade Ruby to 2.6.1
Ruby 2.6.1 contains a fix for Net::HTTP
-
Add 2.6.1 to .ruby-version as well
-
Add 2.6.1 to Travis CI as well](https://github.com/thepracticaldev/dev.to/commit/dd6372012def4c0a645711b6916e7dde020df255) by rhymes
๐ ๏ธ [The issue 'Styling of Edit Post button on your own post' fixed. Closeโฆ (#1749) * The issue 'Styling of Edit Post button on your own post' fixed. Closed #1740 -
I changed margin top to 4 and media screens's max-width value change as 376px](https://github.com/thepracticaldev/dev.to/commit/b9279033a4ace3a7f4d459cdc033c6f5bfd1afe0) by aligoren
๐ ๏ธ [Allow dashboard view for admins and update permissions in internal/users (#1742) * allow admins to see dashboards -
add more info to internal users
-
add more info to internal users
-
add video permission toggle
-
specify banished user traits](https://github.com/thepracticaldev/dev.to/commit/009001272a63cf4ce7aade59491a166a9a8d1382) by jessleenyc
๐ ๏ธ [Added 3 year anniversary badge (#1732) * Added 3 year anniversary badge -
Fix linting error](https://github.com/thepracticaldev/dev.to/commit/1793956bdb1c0c2aa8261b6070a9fd5381e12409) by Glennmen
๐ ๏ธ [Enhance Internal Index Pages (#1747) * add more info to internal users index -
create tag show page and add tag moderation form
-
fix linting
-
add tag index view and alias field
-
add pagination to tag index
-
fix spec](https://github.com/thepracticaldev/dev.to/commit/54426ea20b29314320eee631a6000cb4e413ce0a) by jessleenyc
๐ ๏ธ Remove duplicate husky configuration (#1712) by rhymes๐ ๏ธ Add title to badge images (#1738) by rhymes๐ ๏ธ [Bump cloudinary from 1.9.1 to 1.11.1 (#1721) [ci skip] Bumps cloudinary from 1.9.1 to 1.11.1.
Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/a3bb0b831a5ef1ee762fdc0a2fc96a590379cc71) by dependabot[bot]
Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/0090ee0dbb5b9de618afd732dff09e983e534052) by dependabot[bot]
Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/bf3823e1645e8d4c17b5b5f857ecee1218f8d3a1) by dependabot[bot]
Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/429d35b9a16492b2ee42809cb54f72ded4464d56) by dependabot[bot]
Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/77d66f5423821d1f08f1505861374d84e03f78b9) by dependabot[bot]
Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/5f2bafb8f5b1046ec9d1d6788eb2227064dfbe7d) by dependabot[bot]
-
Refactor moderation spec
-
Remove & replace RequestSpecHelper
-
Update uid to sequence
-
Lower the need for persistence in specs
-
Update moderation spec
-
Update shoulda-matchers
-
Enable backgroundjobs and update commenct spec
-
Fix fail specs
-
Update comment's validations
-
Remove redundent specs
-
Actually turn off DJ
-
Apply run_background_jobs_immediately
-
Remove giveawy specs
-
Create Identity spec](https://github.com/thepracticaldev/dev.to/commit/1137d6fba40893156a06c20c84d6d5cfa46e8246) by maestromac
๐ ๏ธ [Bump eslint-plugin-jsx-a11y from 6.2.0 to 6.2.1 (#1727) Bumps eslint-plugin-jsx-a11y from 6.2.0 to 6.2.1.
Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/aa16cad4297a8281f26f44893841aaadbbb80209) by dependabot[bot]
Missed in initial pass
- Additional --theme-container-color
Missed in initial pass
- Additional --theme-container-color
Missed in initial pass
- Additional --theme-container-color
Missed in initial pass](https://github.com/thepracticaldev/dev.to/commit/9e4d9ecac16a70cbe64c351506cecf3de5e12459) by Link2Twenty
Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/ed03c4cf0cf6f0bac2bc56556ff606f8c8c0ba18) by dependabot[bot]
CONTRIBUTORS
Last week there were 14 contributors.
STARGAZERS
Last week there were 68 stagazers.
RELEASES
Last week there were no releases.
That's all for last week, please
You can also view all Weekly Digests by clicking here.
Your Weekly Digest bot.
๐
That's it for this week! We'll see if there's another weekly digest summary next week...
Top comments (4)
Thanks for your contributions @ben , @link2twenty , @rhymes , @maestromac , @jpachitas , @glennmen , @aligoren , @vaidehijoshi , @peter , @lightalloy , @seanmfox , @kayis , @vorillaz , @jess , @sandordargo , @qm3ster , and @jeoxs !
Hi.
I thinks this articule has an problem with the commits counter. In my case, fron mobile I see it counting fron 1000 to 2000 over again again...
I dont know if you have the same problem.
It's a looping gif that starts from 1000 to 2000. :)
๐๐ I did not know it๐๐