Code Smell 73 - Exceptions for Expected Cases

Exceptions are handy Gotos and flags. Let's abuse them.

TL;DR: Do not use exceptions for flow control.

Problems

• Readability

• Principle of least astonishment Violation.

Solutions

1. Use Exceptions just for unexpected situations.

2. Exceptions handle contract violations. Read the contract.

Sample Code

Wrong

try {
    for (int i = 0;; i++)
        array[i]++;
    } catch (ArrayIndexOutOfBoundsException e) {}

//Endless loop without end condition

Right

for (int index = 0; index < array.length; index++)
        array[index]++;

//index < array.length breaks execution

Detection

This is a semantic smell. Unless we use machine learning linters it will be very difficult to find the mistakes.

Tags

• Readability

Conclusion

Exceptions are handy, and we should definitively use them instead of returning codes.

The boundary between correct usage and wrong usage is blur like so many design principles.

Relations

Code Smell 72 - Return Codes

Maxi Contieri ・ May 28 '21

#webdev #programming #codenewbie #tutorial

Code Smell 26 - Exceptions Polluting

Maxi Contieri ・ Nov 16 '20

#oop #exceptions #tutorial #programming

More info

• Don't use exceptions for flow control

• Java Zone

• Stack Exchange

• Stack Overflow

Credits

Photo by Greg Rosenke on Unsplash

---

When debugging, novices insert corrective code; experts remove defective code.

Richard Pattis

Software Engineering Great Quotes

Maxi Contieri ・ Dec 28 '20

#codenewbie #programming #quotes #software

---

This article is part of the CodeSmell Series.

How to Find the Stinky parts of your Code

Maxi Contieri ・ May 21 '21

#codenewbie #tutorial #codequality #beginners